You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/19 08:33:00 UTC
[jira] [Commented] (CAMEL-11559) NPE when not setting a sampling
interval on client subscriptions
[ https://issues.apache.org/jira/browse/CAMEL-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092787#comment-16092787 ]
ASF GitHub Bot commented on CAMEL-11559:
----------------------------------------
GitHub user ctron opened a pull request:
https://github.com/apache/camel/pull/1833
CAMEL-11559: Work around a NPE in milo 0.1.3
When the sampling interval is unset in the Camel component, then it is passed to milo as `null`. Which is acceptable to the milo API, however internally milo automatically unboxes the value from `Double` to `double` and may run into a NPE by doing so.
This patch assures that, although theoretically acceptable, `null` is never passed in to the Milo API.
Signed-off-by: Jens Reimann <jr...@redhat.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ctron/camel feature/fix_issue_11559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1833
----
commit 1a692127f54990e72dcbf1d56f83b0e3cb9df20e
Author: Jens Reimann <jr...@redhat.com>
Date: 2017-07-19T08:21:33Z
CAMEL-11559: Work around a NPE in milo 0.1.3
When the sampling interval is unset in the Camel component, then it is
passed to milo as 'null'. Which is acceptable to the milo API, however
internally milo automatically unboxes the value from 'Double' to
'double' and may run into a NPE by doing so.
This patch assures that, although theoretically acceptable,
'null' is never passed in to the Milo API.
Signed-off-by: Jens Reimann <jr...@redhat.com>
----
> NPE when not setting a sampling interval on client subscriptions
> ----------------------------------------------------------------
>
> Key: CAMEL-11559
> URL: https://issues.apache.org/jira/browse/CAMEL-11559
> Project: Camel
> Issue Type: Bug
> Affects Versions: 2.19.1
> Reporter: Jens Reimann
> Labels: easyfix
> Fix For: 2.19.2
>
>
> Due to an internal unintended auto-unboxing from {{Double}} to {{double}} milo may run into an NPE when the sampling interval is unset in the camel-milo component.
> I will provide a fix for this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)