You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/07 04:55:51 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #16425: [PIP-136] Sync Pulsar metadata across multiple clouds

mattisonchao commented on code in PR #16425:
URL: https://github.com/apache/pulsar/pull/16425#discussion_r1041758135


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -350,7 +353,8 @@ public PulsarService(ServiceConfiguration config,
         this.offloaderStats = LedgerOffloaderStats.create(false, false, null, 0);
     }
 
-    public MetadataStore createConfigurationMetadataStore() throws MetadataStoreException {
+    public MetadataStore createConfigurationMetadataStore(PulsarMetadataEventSynchronizer synchronizer)

Review Comment:
   This broke the broker's public API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org