You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Garret Wilson <ga...@globalmentor.com> on 2008/10/13 00:28:53 UTC
Re: non-LF line endings in log message
So it seems as if this issue has fallen through the cracks because the
Subversion team and the Subclipse team keep passing the buck back and
forth. I can't even file a bug report because I don't know where to file
it---nobody will take responsibility for it. I suppose I could just file
it in both places.
This problem still exists using the *very* latest of everything: Eclipse
3.4.1, WTP-WST 3.0.3, and Subclipse 1.4.5.
This issue occurs using Apache mod_dav on the server side.
This should be easy to reproduce: install the software versions I
mentioned, put Subversion behind Apache mod_dav, and try to use
Subclipse to check in any message in which you've used the Enter key to
create multiple lines.
Garret
P.S. I don't get it---am I the only one using multiple lines in my
Subclipse commit messages? Why does no one care about this?
Mark Phippard wrote:
> On Tue, Aug 5, 2008 at 11:26 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>
>>> If this is some new API requirement and JavaHL was not updated to
>>> support it, then a bug should be opened. I am still not clear if that
>>> is the case or not.
>>>
>> It's not a new API requirement; the C API has put the burden to
>> normalise the log message on libsvn_client's consumer since 1.0.0.
>> (Refer to the documentation of svn_client_get_commit_log_t.)
>>
>>
>>> Perhaps Daniel can look into it and open an issue if that is the case.
>>>
>> We'd only need an issue if it is JavaHL -- rather than the JavaHL
>> consumers -- who should be doing the translation. I'm not qualified to
>> make that call, so I'll not open an issue for now.
>>
>
> What is a valid test case for this?
>
> I have a Windows system with latest Subclipse (with JavaHL 1.5.1). I
> can commit to a Linux server (also running 1.5.1) via http and I do
> not get an error. I used a multi-line commit message.
>
> Garret what protocol were you using? I can try with that protocol too.
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: non-LF line endings in log message
Posted by Garret Wilson <ga...@globalmentor.com>.
Garret Wilson wrote:
> Daniel Shahaf wrote:
>> Because the error doesn't exist in a released version? (Mark: this
>> explains why you couldn't reproduce with 1.5.1 server.) You originally
>> said that the error you had was "Cannot accept non-LF line endings in
>> log message"; that error is from validate_prop() in trunk, but has not
>> been backported to 1.5.x.
>>
>> What version of Subversion is your server running?
>>
>
> On the server I'm currently using r33942 from trunk.
I'm sorry--scratch that. My server seems to be r33072 from trunk.
Garret
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: non-LF line endings in log message
Posted by Garret Wilson <ga...@globalmentor.com>.
Daniel Shahaf wrote:
> Garret Wilson wrote on Sun, 12 Oct 2008 at 17:28 -0700:
>
>> P.S. I don't get it---am I the only one using multiple lines in my Subclipse
>> commit messages? Why does no one care about this?
>>
>>
>
> Because the error doesn't exist in a released version? (Mark: this
> explains why you couldn't reproduce with 1.5.1 server.) You originally
> said that the error you had was "Cannot accept non-LF line endings in
> log message"; that error is from validate_prop() in trunk, but has not
> been backported to 1.5.x.
>
> What version of Subversion is your server running?
>
On the server I'm currently using r33942 from trunk.
Garret
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: non-LF line endings in log message
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Garret Wilson wrote on Sun, 12 Oct 2008 at 17:28 -0700:
> So it seems as if this issue has fallen through the cracks because the
> Subversion team and the Subclipse team keep passing the buck back and forth. I
> can't even file a bug report because I don't know where to file it---nobody
> will take responsibility for it. I suppose I could just file it in both
> places.
>
> This problem still exists using the *very* latest of everything: Eclipse
> 3.4.1, WTP-WST 3.0.3, and Subclipse 1.4.5.
>
> This issue occurs using Apache mod_dav on the server side.
>
> This should be easy to reproduce: install the software versions I mentioned,
> put Subversion behind Apache mod_dav, and try to use Subclipse to check in any
> message in which you've used the Enter key to create multiple lines.
>
> Garret
>
> P.S. I don't get it---am I the only one using multiple lines in my Subclipse
> commit messages? Why does no one care about this?
>
Because the error doesn't exist in a released version? (Mark: this
explains why you couldn't reproduce with 1.5.1 server.) You originally
said that the error you had was "Cannot accept non-LF line endings in
log message"; that error is from validate_prop() in trunk, but has not
been backported to 1.5.x.
What version of Subversion is your server running?
> Mark Phippard wrote:
> > On Tue, Aug 5, 2008 at 11:26 AM, Daniel Shahaf <d....@daniel.shahaf.name>
> > wrote:
> >
> > > > If this is some new API requirement and JavaHL was not updated to
> > > > support it, then a bug should be opened. I am still not clear if that
> > > > is the case or not.
> > > >
> > > It's not a new API requirement; the C API has put the burden to
> > > normalise the log message on libsvn_client's consumer since 1.0.0.
> > > (Refer to the documentation of svn_client_get_commit_log_t.)
> > >
> > >
> > > > Perhaps Daniel can look into it and open an issue if that is the case.
> > > >
> > > We'd only need an issue if it is JavaHL -- rather than the JavaHL
> > > consumers -- who should be doing the translation. I'm not qualified to
> > > make that call, so I'll not open an issue for now.
> > >
> >
> > What is a valid test case for this?
> >
> > I have a Windows system with latest Subclipse (with JavaHL 1.5.1). I
> > can commit to a Linux server (also running 1.5.1) via http and I do
> > not get an error. I used a multi-line commit message.
> >
> > Garret what protocol were you using? I can try with that protocol too.
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org