You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Raul Castro Fernandez <ra...@contxt.in> on 2014/08/19 19:54:57 UTC

Re: Review Request 23647: Patch for KAFKA-1526

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23647/
-----------------------------------------------------------

(Updated Aug. 19, 2014, 5:54 p.m.)


Review request for kafka.


Bugs: KAFKA-1526
    https://issues.apache.org/jira/browse/KAFKA-1526


Repository: kafka


Description (updated)
-------

KAFKA-1526; producer perf tool with tx updated with new options to measure rtt and e2e latency


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/internals/RTTLoggingCallback.java PRE-CREATION 
  core/src/main/scala/kafka/producer/BaseProducer.scala b0207930dd0543f2c51f0b35002e13bf104340ff 
  core/src/main/scala/kafka/tools/ProducerPerformance.scala fc3e7241dda0672deb8c5ce5d7c983c320ec45ee 

Diff: https://reviews.apache.org/r/23647/diff/


Testing
-------


Thanks,

Raul Castro Fernandez

Re: Review Request 23647: Patch for KAFKA-1526

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23647/#review51056
-----------------------------------------------------------

Ship it!


Minor comments.


clients/src/main/java/org/apache/kafka/clients/producer/internals/RTTLoggingCallback.java
<https://reviews.apache.org/r/23647/#comment88978>

    Would rather have this nested inside producer performance.



core/src/main/scala/kafka/tools/ProducerPerformance.scala
<https://reviews.apache.org/r/23647/#comment88977>

    Can combine this block with the one below to some degree.


- Joel Koshy


On Aug. 19, 2014, 5:54 p.m., Raul Castro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23647/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:54 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1526
>     https://issues.apache.org/jira/browse/KAFKA-1526
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1526; producer perf tool with tx updated with new options to measure rtt and e2e latency
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RTTLoggingCallback.java PRE-CREATION 
>   core/src/main/scala/kafka/producer/BaseProducer.scala b0207930dd0543f2c51f0b35002e13bf104340ff 
>   core/src/main/scala/kafka/tools/ProducerPerformance.scala fc3e7241dda0672deb8c5ce5d7c983c320ec45ee 
> 
> Diff: https://reviews.apache.org/r/23647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raul Castro Fernandez
> 
>