[GitHub] mhenke1 opened a new pull request #4187: Handle kafka exception thrown when creating the admin client

[GitBox <gi...@apache.org>]

mhenke1 opened a new pull request #4187: Handle kafka exception thrown when creating the admin client
URL: https://github.com/apache/incubator-openwhisk/pull/4187
 
 
   ## Description
   The KafkaMessagingProvider does not handle KafkaExceptions that are thrown when creating the admin client. Not handling these exceptions kills the invokers main thread (see stack trace below).
   
   ```
   Exception in thread "main" org.apache.kafka.common.KafkaException: Failed create new KafkaAdminClient
           at org.apache.kafka.clients.admin.KafkaAdminClient.createInternal(KafkaAdminClient.java:370)
           at org.apache.kafka.clients.admin.AdminClient.create(AdminClient.java:52)
           at org.apache.openwhisk.connector.kafka.KafkaMessagingProvider$.ensureTopic(KafkaMessagingProvider.scala:63)
           at org.apache.openwhisk.core.invoker.Invoker$.main(Invoker.scala:156)
           at org.apache.openwhisk.core.invoker.Invoker.main(Invoker.scala)
   ```
   
   ## Related issue and scope
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services