You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/10/13 09:59:57 UTC

[I] Support Oracle merge statement convert to SqlMerge to improve sql federation support [shardingsphere]

strongduanmu opened a new issue, #28754:
URL: https://github.com/apache/shardingsphere/issues/28754

   ## Background
   
   On the master branch, [SQLNodeConverterEngine](https://github.com/apache/shardingsphere/blob/master/kernel/sql-federation/core/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/converter/SQLNodeConverterEngine.java) already supports the conversion of most SelectStatement statements, which provides a good foundation for sql federation. In order to improve the support of sql federation for merge statement, we need to support the conversion of MergeStatement in SQLNodeConverterEngine.
   
   Oracle merge statement doc - https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/MERGE.html#GUID-5692CCB7-24D9-4C0E-81A7-A22436DC968F
   
   ## Task
   
   - [ ] add DropTableStatementConverter implement, you can refer - https://github.com/polardb/polardbx-sql/blob/cdd976850bdfc3264dff279198b6b06eb8641fbe/polardbx-optimizer/src/main/java/com/alibaba/polardbx/optimizer/parse/visitor/FastSqlToCalciteNodeVisitor.java#L786
   - [ ] add DropTableStatementConverter call logic in SQLNodeConverterEngine
   - [ ] add drop table statement convert test case in `resources/converter` directory
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support Oracle merge statement convert to SqlMerge to improve sql federation support [shardingsphere]

Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on issue #28754:
URL: https://github.com/apache/shardingsphere/issues/28754#issuecomment-1762218553

   @strongduanmu Please assign :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support Oracle merge statement convert to SqlMerge to improve sql federation support [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #28754:
URL: https://github.com/apache/shardingsphere/issues/28754#issuecomment-1808963780

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support Oracle merge statement convert to SqlMerge to improve sql federation support [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #28754:
URL: https://github.com/apache/shardingsphere/issues/28754#issuecomment-1762461152

   @kanha-gupta Welcome, I just assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org