You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/21 11:11:20 UTC
[GitHub] [arrow-cookbook] thisisnic opened a new pull request #90: [R] - Flight recipes
thisisnic opened a new pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90
I haven't written tests for these due to the inherent complexity in doing so (is it possible?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace commented on a change in pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#discussion_r737841384
##########
File path: r/content/flight.Rmd
##########
@@ -0,0 +1,104 @@
+# Flight
+
+## Introduction
+
+Flight is a general-purpose client-server framework for high performance
+transport of large datasets over network interfaces, built as part of the
+Apache Arrow project.
+
+Flight allows for highly efficient data transfer as it:
+
+* removes the need for deserialization during data transfer
Review comment:
```suggestion
* removes the need for serialization during data transfer
```
Super minor nit and it's probably fine as it is but if you don't need deserialization you also don't need serialization. Flight removes the need for both. That being said, it's kind of wordy to say "removes the need for serialization and deserialization during data transfer". So usually, when I see the general topic (and not just one end) being discussed the term "serialization" is used instead of "deserialization".
It's sort of like one might say "I take the train because I hate driving to work every day" and they (presumably) mean they hate both "driving to work" and "driving home from work" and it would be just a little odd to hear "I take the train because I hate driving home from work every day."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] ianmcook commented on pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#issuecomment-951007600
Thanks for doing this Nic! I think it is worth briefly noting somewhere here in the Cookbook article that the Flight implementation in the R package depends on PyArrow and uses reticulate to call it. This is quite different from the other capabilities in the R package, nearly all of which are all implemented directly, not through PyArrow via reticulate, so I think it's worth calling out explicitly, not just via a link to the vignette.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] ianmcook commented on pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#issuecomment-951008628
I agree that adding tests is probably not worth the trouble in this particular case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] thisisnic merged pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
thisisnic merged pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] thisisnic commented on pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#issuecomment-951308134
> the Flight implementation in the R package depends on PyArrow and uses reticulate to call it. This is quite different from the other capabilities in the R package, nearly all of which are all implemented directly, not through PyArrow via reticulate, so I think it's worth calling out explicitly, not just via a link to the vignette.
Done. Wasn't sure what else to say about it so have ever so slightly rephrased this comment into the cookbook - let me know if anything else would be useful to mention there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#discussion_r738204656
##########
File path: r/content/flight.Rmd
##########
@@ -0,0 +1,104 @@
+# Flight
+
+## Introduction
+
+Flight is a general-purpose client-server framework for high performance
+transport of large datasets over network interfaces, built as part of the
+Apache Arrow project.
+
+Flight allows for highly efficient data transfer as it:
+
+* removes the need for deserialization during data transfer
Review comment:
Thanks - that makes sense! Once again, you have great explanations for things :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] thisisnic edited a comment on pull request #90: [R] - Flight recipes
Posted by GitBox <gi...@apache.org>.
thisisnic edited a comment on pull request #90:
URL: https://github.com/apache/arrow-cookbook/pull/90#issuecomment-951308134
> the Flight implementation in the R package depends on PyArrow and uses reticulate to call it. This is quite different from the other capabilities in the R package, nearly all of which are all implemented directly, not through PyArrow via reticulate, so I think it's worth calling out explicitly, not just via a link to the vignette.
Done; thanks for the review! Wasn't sure what else to say about it so have ever so slightly rephrased this comment into the cookbook - let me know if anything else would be useful to mention there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org