You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/20 05:22:49 UTC

[GitHub] [hudi] vinothchandar commented on a change in pull request #2111: [HUDI-1234] Insert new records to data files without merging for "Insert" operation.

vinothchandar commented on a change in pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#discussion_r560686629



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -133,6 +133,10 @@
   private static final String MERGE_DATA_VALIDATION_CHECK_ENABLED = "hoodie.merge.data.validation.enabled";
   private static final String DEFAULT_MERGE_DATA_VALIDATION_CHECK_ENABLED = "false";
 
+  // Concats inserts to data files without merging
+  private static final String MERGE_ALLOW_DUPLICATE_INSERTS = "hoodie.merge.allow.duplicate.inserts";

Review comment:
       first one is too long IMO. I think `hoodie.merge.allow.duplicates.on.insert` is a better name (I added the `.on`) given it explains to the user what the impact is. Whether we concat or prepend in implementation, thats not very useful for the end user




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org