You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/11 09:46:04 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request #271: IGNITE-15286 Fixed imports order & chackstyle/codestyle rules added.
ibessonov opened a new pull request #271:
URL: https://github.com/apache/ignite-3/pull/271
https://issues.apache.org/jira/browse/IGNITE-15286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #271: IGNITE-15286 Fixed imports order & checkstyle/codestyle rules added.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #271:
URL: https://github.com/apache/ignite-3/pull/271#discussion_r686679496
##########
File path: check-rules/checkstyle-rules.xml
##########
@@ -112,5 +112,16 @@
See: https://checkstyle.sourceforge.io/config_whitespace.html#SingleSpaceSeparator
-->
<module name="SingleSpaceSeparator"/>
+
+ <module name="AvoidStarImport"/>
+
+ <module name="CustomImportOrder">
Review comment:
```suggestion
<!--
Checks imports order.
See: https://checkstyle.sourceforge.io/config_imports.html#CustomImportOrder
-->
<module name="CustomImportOrder">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #271: IGNITE-15286 Fixed imports order & checkstyle/codestyle rules added.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #271:
URL: https://github.com/apache/ignite-3/pull/271#discussion_r686678236
##########
File path: check-rules/checkstyle-rules.xml
##########
@@ -112,5 +112,16 @@
See: https://checkstyle.sourceforge.io/config_whitespace.html#SingleSpaceSeparator
-->
<module name="SingleSpaceSeparator"/>
+
Review comment:
```suggestion
<!--
Checks that no wildcard imports used..
See: https://checkstyle.sourceforge.io/config_imports.html#AvoidStarImport
-->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #271: IGNITE-15286 Fixed imports order & checkstyle/codestyle rules added.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #271:
URL: https://github.com/apache/ignite-3/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #271: IGNITE-15286 Fixed imports order & checkstyle/codestyle rules added.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #271:
URL: https://github.com/apache/ignite-3/pull/271#discussion_r686678236
##########
File path: check-rules/checkstyle-rules.xml
##########
@@ -112,5 +112,16 @@
See: https://checkstyle.sourceforge.io/config_whitespace.html#SingleSpaceSeparator
-->
<module name="SingleSpaceSeparator"/>
+
Review comment:
```suggestion
<!--
Checks that no wildcard imports used.
See: https://checkstyle.sourceforge.io/config_imports.html#AvoidStarImport
-->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org