You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/08/23 15:39:06 UTC

[GitHub] milleruntime commented on a change in pull request #613: Removed all use of SiteConfiguration.getInstance()

milleruntime commented on a change in pull request #613: Removed all use of SiteConfiguration.getInstance()
URL: https://github.com/apache/accumulo/pull/613#discussion_r212347364
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthorizor.java
 ##########
 @@ -51,22 +52,21 @@
 
   private final String ZKUserAuths = "/Authorizations";
 
+  private ServerContext context;
   private String ZKUserPath;
-  private final ZooCache zooCache;
+  private ZooCache zooCache;
 
   public static synchronized Authorizor getInstance() {
 
 Review comment:
   Another place we could get rid of static state.  Could create a follow on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services