[GitHub] [flink] RocMarshal commented on a change in pull request #19169: [FLINK-26747][flink-external-resource-gpu][JUnit5 Migration] Module: flink-external-resources

[GitBox <gi...@apache.org>]

RocMarshal commented on a change in pull request #19169:
URL: https://github.com/apache/flink/pull/19169#discussion_r830996045



##########
File path: flink-external-resources/flink-external-resource-gpu/src/test/java/org/apache/flink/externalresource/gpu/GPUDiscoveryScriptTest.java
##########
@@ -19,41 +19,40 @@
 package org.apache.flink.externalresource.gpu;
 
 import org.apache.flink.util.OperatingSystem;
-import org.apache.flink.util.TestLogger;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
 
-import static org.junit.Assume.assumeTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 /** Tests for the gpu-discovery-common.sh. */
-public class GPUDiscoveryScriptTest extends TestLogger {
+class GPUDiscoveryScriptTest {
 
     private static final String TEST_SCRIPT_PATH = "src/test/resources/test-coordination-mode.sh";
 
     @Test
-    public void testNonCoordinationMode() throws Exception {
-        assumeTrue(OperatingSystem.isLinux());
+    void testNonCoordinationMode() throws Exception {
+        assertThat(OperatingSystem.isLinux()).isTrue();

Review comment:
       @zentol  Thank you very much for the good catch. I'm so sorry for the rookie mistake. I'll check it carefully




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org