[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9801: AdaptiveServerSelection: Update stats for servers that have not responded

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9801:
URL: https://github.com/apache/pinot/pull/9801#discussion_r1022358135


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##########
@@ -134,7 +148,15 @@ void markRequestSent(ServerRoutingInstance serverRoutingInstance, int requestSen
 
   void receiveDataTable(ServerRoutingInstance serverRoutingInstance, DataTable dataTable, int responseSize,
       int deserializationTimeMs) {
-    _responseMap.get(serverRoutingInstance).receiveDataTable(dataTable, responseSize, deserializationTimeMs);
+    ServerResponse response = _responseMap.get(serverRoutingInstance);
+    response.receiveDataTable(dataTable, responseSize, deserializationTimeMs);
+
+    // Record query completion stats immediately after receiving the response from the server instead of waiting

Review Comment:
   Not sure I follow this change. Was this a bug ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org