You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2024/07/04 21:20:09 UTC
[PR] [MINOR] Add LibReplace for MatrixBlock [systemds]
Baunsgaard opened a new pull request, #2043:
URL: https://github.com/apache/systemds/pull/2043
This PR separate the replace logic from the internals of the MatrixBlock, adding a LibReplace class.
The change follows the style of adding lib packages, and it improves the replace performance by .... (see next comment.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Add LibReplace for MatrixBlock [systemds]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2043:
URL: https://github.com/apache/systemds/pull/2043#issuecomment-2209587118
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2043?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `96.39640%` with `4 lines` in your changes missing coverage. Please review.
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`main@a95effa`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
| [Files](https://app.codecov.io/gh/apache/systemds/pull/2043?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/sysds/runtime/matrix/data/LibMatrixReplace.java](https://app.codecov.io/gh/apache/systemds/pull/2043?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fmatrix%2Fdata%2FLibMatrixReplace.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvbWF0cml4L2RhdGEvTGliTWF0cml4UmVwbGFjZS5qYXZh) | 96.36% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2043 +/- ##
=======================================
Coverage ? 68.83%
Complexity ? 40699
=======================================
Files ? 1440
Lines ? 161515
Branches ? 31416
=======================================
Hits ? 111179
Misses ? 41267
Partials ? 9069
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2043?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Add LibReplace for MatrixBlock [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2043:
URL: https://github.com/apache/systemds/pull/2043#issuecomment-2209596740
The main benefit in this PR is when we perform replacement on a sparse matrix, and the output is dense.
on a 10k x 10k 0.1 sparse matrix
After
```
java -jar target/systemds-3.3.0-SNAPSHOT-perf.jar 17 10000 10000 0.1 16
Profiling started
replaceZero, 132.883+- 9.335 ms,
replaceOne, 59.612+- 3.295 ms,
replaceNaN, 10.651+- 0.470 ms,
```
Before
```
java -jar target/systemds-3.3.0-SNAPSHOT-perf.jar 17 10000 10000 0.1 1
Profiling started
replaceZero, 228.727+- 11.965 ms,
replaceOne, 163.212+- 4.993 ms,
replaceNaN, 10.602+- 0.437 ms,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Add LibReplace for MatrixBlock [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2043: [MINOR] Add LibReplace for MatrixBlock
URL: https://github.com/apache/systemds/pull/2043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org