You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/01/06 14:00:00 UTC
[jira] [Commented] (IMPALA-11827) do not cache admission control service's IP address in coordinator
[ https://issues.apache.org/jira/browse/IMPALA-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655460#comment-17655460 ]
ASF subversion and git services commented on IMPALA-11827:
----------------------------------------------------------
Commit f0e602dbb9e8bada186b4b4a214c636e2bc65e7d in impala's branch refs/heads/master from Abhishek Rawat
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f0e602dbb ]
IMPALA-11827: do not cache admission control service's IP address in impalad
The Impalad's ExecEnv caches resolved IP address for admission control
service. The Impala server runs a heart beat thread for admission
control service and it relies on the cached resolved address in ExecEnv.
This breaks when IP address for admission control services changes.
This patch removes the 'admission_service_address_' member and its
getter in the ExecEnv class and adds a GetAdmissionServiceAddress()
interface to dynamically get the resolved address, if global admission
control service is enabled ('admission_service_host' flag is set).
Testing: Manually tested by restarting global admission controller
service in a Kubernetes setup where it gets new IP address on startup.
Coordinator's admission heart beat thread was able to connect to the
admission control service using the new IP address. Also made sure that
the coordinator and admissiond communication was working as expected
upon admissiond restarts.
Change-Id: I09b4c52644f9e1b3c1f0e68c9900464d722517af
Reviewed-on: http://gerrit.cloudera.org:8080/19403
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> do not cache admission control service's IP address in coordinator
> ------------------------------------------------------------------
>
> Key: IMPALA-11827
> URL: https://issues.apache.org/jira/browse/IMPALA-11827
> Project: IMPALA
> Issue Type: Task
> Reporter: Abhishek Rawat
> Assignee: Abhishek Rawat
> Priority: Major
>
> The Impalad's ExecEnv caches resolved IP address for admission control service:
> [https://github.com/apache/impala/blob/master/be/src/runtime/exec-env.h#L301]
> The Impala server runs a heart beat thread for admission control service and it relies on the cached resolved address in ExecEnv:
> [https://github.com/apache/impala/blob/master/be/src/service/impala-server.cc#L584]
> This breaks when IP address for admission control services changes and so we shouldn't cache dynamic addresses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org