[GitHub] [cloudstack] soreana commented on pull request #6918: Override vr service offering

["soreana (via GitHub)" <gi...@apache.org>]

soreana commented on PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1496141127

   @DaanHoogland I removed these lines and the build error gone. I don't know what was wrong. 🤷‍♂️ 
   
   
   ```diff
   diff --git a/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java b/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
   index 33747b0342..6beba0b212 100644
   --- a/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
   +++ b/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
   @@ -56,7 +56,6 @@ import com.cloud.network.dao.FirewallRulesDcidrsDaoImpl;
    import com.cloud.network.dao.IPAddressDaoImpl;
    import com.cloud.network.dao.LoadBalancerDao;
    import com.cloud.network.dao.NetworkDao;
   -import com.cloud.network.dao.NetworkDetailsDao;
    import com.cloud.network.dao.NetworkDomainDaoImpl;
    import com.cloud.network.dao.NetworkServiceMapDaoImpl;
    import com.cloud.network.dao.PhysicalNetworkDaoImpl;
   @@ -325,11 +324,6 @@ public class
            return Mockito.mock(DomainDetailsDao.class);
        }
    
   -    @Bean
   -    public NetworkDetailsDao networkDetailsDao() {
   -        return Mockito.mock(NetworkDetailsDao.class);
   -    }
   -
        @Bean
        public DataStoreManager dataStoreManager() {
            return Mockito.mock(DataStoreManager.class);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org