You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Carsten Ziegeler <cz...@apache.org> on 2022/11/29 06:25:38 UTC

[VOTE] Release Apache Sling Engine 2.13.0

Hi,

We solved 1 issue in this release
https://issues.apache.org/jira/projects/SLING/versions/12352598


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2698

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2698 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe
cziegeler@apache.org

RE: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
+1

stefan

Re: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Carsten Ziegeler <cz...@apache.org>.
+1

Carsten

Am 29.11.2022 um 07:25 schrieb Carsten Ziegeler:
> Hi,
> 
> We solved 1 issue in this release
> https://issues.apache.org/jira/projects/SLING/versions/12352598
> 
> 
> Staging repository: 
> https://repository.apache.org/content/repositories/orgapachesling-2698
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2698 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>    [ ] +1 Approve the release
>    [ ]  0 Don't care
>    [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards
> Carsten

-- 
Carsten Ziegeler
Adobe
cziegeler@apache.org

Re: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Karl Pauls <ka...@gmail.com>.
+1

regards,

Karl

On Wed, Nov 30, 2022 at 8:32 PM Eric Norman <en...@apache.org> wrote:

> Hi Carsten,
>
> Thanks for the follow up.  I'm satisfied with the explanation and
> solutions.  The tests are all working now for me.
>
> +1 for me.
>
> Regards,
> Eric
>
> On Wed, Nov 30, 2022 at 3:57 AM Carsten Ziegeler <cz...@apache.org>
> wrote:
>
> > Thanks Eric,
> >
> > the errors are caused by two things:
> > a) wrongly written error handlers as part of the tests. As we document
> > an error handler needs to set the status code (if different from 200).
> > The test ones didn't do that. I fixed the error handlers.
> > b) the other failing tests are actually testing what is now fixed in the
> > engine. when a response can't be reset, an error handler must not output
> > anything. However, some tests are checking this. Increasing the response
> > buffer (which I did in the starter now for the tests), fixes that
> problem.
> >
> > So I think, there is no problem with the new engine release.
> >
> > Regards
> > Carsten
> >
> > Am 29.11.2022 um 20:12 schrieb Eric Norman:
> > > -1 for me.
> > >
> > > Switching to this artifact introduces 7 new failures in the starter
> > > integration tests that need to be remedied or explained.
> > >
> > > Most of the failures appear to be related to the wrong status code
> > arriving
> > > with the error pages.
> > >
> > > Regards,
> > > Eric
> > >
> > > On Mon, Nov 28, 2022 at 10:25 PM Carsten Ziegeler <
> cziegeler@apache.org>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> We solved 1 issue in this release
> > >> https://issues.apache.org/jira/projects/SLING/versions/12352598
> > >>
> > >>
> > >> Staging repository:
> > >>
> https://repository.apache.org/content/repositories/orgapachesling-2698
> > >>
> > >> You can use this UNIX script to download the release and verify the
> > >> signatures:
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > >>
> > >> Usage:
> > >> sh check_staged_release.sh 2698 /tmp/sling-staging
> > >>
> > >> Please vote to approve this release:
> > >>
> > >>     [ ] +1 Approve the release
> > >>     [ ]  0 Don't care
> > >>     [ ] -1 Don't release, because ...
> > >>
> > >> This majority vote is open for at least 72 hours.
> > >>
> > >> Regards
> > >> Carsten
> > >> --
> > >> Carsten Ziegeler
> > >> Adobe
> > >> cziegeler@apache.org
> > >>
> > >
> >
> > --
> > Carsten Ziegeler
> > Adobe
> > cziegeler@apache.org
> >
>


-- 
Karl Pauls
karlpauls@gmail.com

Re: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Eric Norman <en...@apache.org>.
Hi Carsten,

Thanks for the follow up.  I'm satisfied with the explanation and
solutions.  The tests are all working now for me.

+1 for me.

Regards,
Eric

On Wed, Nov 30, 2022 at 3:57 AM Carsten Ziegeler <cz...@apache.org>
wrote:

> Thanks Eric,
>
> the errors are caused by two things:
> a) wrongly written error handlers as part of the tests. As we document
> an error handler needs to set the status code (if different from 200).
> The test ones didn't do that. I fixed the error handlers.
> b) the other failing tests are actually testing what is now fixed in the
> engine. when a response can't be reset, an error handler must not output
> anything. However, some tests are checking this. Increasing the response
> buffer (which I did in the starter now for the tests), fixes that problem.
>
> So I think, there is no problem with the new engine release.
>
> Regards
> Carsten
>
> Am 29.11.2022 um 20:12 schrieb Eric Norman:
> > -1 for me.
> >
> > Switching to this artifact introduces 7 new failures in the starter
> > integration tests that need to be remedied or explained.
> >
> > Most of the failures appear to be related to the wrong status code
> arriving
> > with the error pages.
> >
> > Regards,
> > Eric
> >
> > On Mon, Nov 28, 2022 at 10:25 PM Carsten Ziegeler <cz...@apache.org>
> > wrote:
> >
> >> Hi,
> >>
> >> We solved 1 issue in this release
> >> https://issues.apache.org/jira/projects/SLING/versions/12352598
> >>
> >>
> >> Staging repository:
> >> https://repository.apache.org/content/repositories/orgapachesling-2698
> >>
> >> You can use this UNIX script to download the release and verify the
> >> signatures:
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>
> >> Usage:
> >> sh check_staged_release.sh 2698 /tmp/sling-staging
> >>
> >> Please vote to approve this release:
> >>
> >>     [ ] +1 Approve the release
> >>     [ ]  0 Don't care
> >>     [ ] -1 Don't release, because ...
> >>
> >> This majority vote is open for at least 72 hours.
> >>
> >> Regards
> >> Carsten
> >> --
> >> Carsten Ziegeler
> >> Adobe
> >> cziegeler@apache.org
> >>
> >
>
> --
> Carsten Ziegeler
> Adobe
> cziegeler@apache.org
>

Re: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Carsten Ziegeler <cz...@apache.org>.
Thanks Eric,

the errors are caused by two things:
a) wrongly written error handlers as part of the tests. As we document 
an error handler needs to set the status code (if different from 200). 
The test ones didn't do that. I fixed the error handlers.
b) the other failing tests are actually testing what is now fixed in the 
engine. when a response can't be reset, an error handler must not output 
anything. However, some tests are checking this. Increasing the response 
buffer (which I did in the starter now for the tests), fixes that problem.

So I think, there is no problem with the new engine release.

Regards
Carsten

Am 29.11.2022 um 20:12 schrieb Eric Norman:
> -1 for me.
> 
> Switching to this artifact introduces 7 new failures in the starter
> integration tests that need to be remedied or explained.
> 
> Most of the failures appear to be related to the wrong status code arriving
> with the error pages.
> 
> Regards,
> Eric
> 
> On Mon, Nov 28, 2022 at 10:25 PM Carsten Ziegeler <cz...@apache.org>
> wrote:
> 
>> Hi,
>>
>> We solved 1 issue in this release
>> https://issues.apache.org/jira/projects/SLING/versions/12352598
>>
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2698
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>>
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2698 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>     [ ] +1 Approve the release
>>     [ ]  0 Don't care
>>     [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Regards
>> Carsten
>> --
>> Carsten Ziegeler
>> Adobe
>> cziegeler@apache.org
>>
> 

-- 
Carsten Ziegeler
Adobe
cziegeler@apache.org

Re: [VOTE] Release Apache Sling Engine 2.13.0

Posted by Eric Norman <en...@apache.org>.
-1 for me.

Switching to this artifact introduces 7 new failures in the starter
integration tests that need to be remedied or explained.

Most of the failures appear to be related to the wrong status code arriving
with the error pages.

Regards,
Eric

On Mon, Nov 28, 2022 at 10:25 PM Carsten Ziegeler <cz...@apache.org>
wrote:

> Hi,
>
> We solved 1 issue in this release
> https://issues.apache.org/jira/projects/SLING/versions/12352598
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2698
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2698 /tmp/sling-staging
>
> Please vote to approve this release:
>
>    [ ] +1 Approve the release
>    [ ]  0 Don't care
>    [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe
> cziegeler@apache.org
>

[VOTE RESULT] Release Apache Sling Engine 2.13.0

Posted by Carsten Ziegeler <cz...@apache.org>.
The vote passes with four binding +1 votes

Thanks
Carsten
-- 
Carsten Ziegeler
Adobe
cziegeler@apache.org