You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/04/23 18:03:50 UTC
Review Request: SQOOP-1008 Test TestClassWriter.testNoClassGeneration is
failing on JDK7
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10731/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've changed expectation of IOException to just an Exception.
This addresses bug SQOOP-1008.
https://issues.apache.org/jira/browse/SQOOP-1008
Diffs
-----
src/test/com/cloudera/sqoop/orm/TestClassWriter.java 6158fb438babc967f28702301619807e9e0a9c3c
Diff: https://reviews.apache.org/r/10731/diff/
Testing
-------
The test seems to be passing on both JDK6 and JDK7.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-1008 Test TestClassWriter.testNoClassGeneration is
failing on JDK7
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10731/#review19586
-----------------------------------------------------------
Ship it!
It looks good. This should catch any cause of exception irrespective of the underlying behavior
- Venkat Ranganathan
On April 23, 2013, 4:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10731/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 4:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed expectation of IOException to just an Exception.
>
>
> This addresses bug SQOOP-1008.
> https://issues.apache.org/jira/browse/SQOOP-1008
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 6158fb438babc967f28702301619807e9e0a9c3c
>
> Diff: https://reviews.apache.org/r/10731/diff/
>
>
> Testing
> -------
>
> The test seems to be passing on both JDK6 and JDK7.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-1008 Test TestClassWriter.testNoClassGeneration is
failing on JDK7
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10731/#review19606
-----------------------------------------------------------
Ship it!
Ship It!
- Kathleen Ting
On April 23, 2013, 4:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10731/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 4:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed expectation of IOException to just an Exception.
>
>
> This addresses bug SQOOP-1008.
> https://issues.apache.org/jira/browse/SQOOP-1008
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 6158fb438babc967f28702301619807e9e0a9c3c
>
> Diff: https://reviews.apache.org/r/10731/diff/
>
>
> Testing
> -------
>
> The test seems to be passing on both JDK6 and JDK7.
>
>
> Thanks,
>
> Jarek Cecho
>
>