You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/20 15:16:04 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #11392: [IR] Renamed __VisitAttrs__ and __fvisit__ to non-reserved names

Lunderberg opened a new pull request, #11392:
URL: https://github.com/apache/tvm/pull/11392

   All names beginning with two underscores are reserved for the compiler and standard library, even if they occur inside a class or namespace ([relevant stackoverflow](https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier)).  While I'm unaware of any existing issues this would cause, this avoids potential compiler incompatibility in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #11392: [IR] Renamed __VisitAttrs__ and __fvisit__ to non-reserved names

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11392:
URL: https://github.com/apache/tvm/pull/11392#issuecomment-1133284873

   TIL didn't know that before!
   
   CC: @tqchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #11392: [IR] Renamed __VisitAttrs__ and __fvisit__ to non-reserved names

Posted by GitBox <gi...@apache.org>.
tqchen merged PR #11392:
URL: https://github.com/apache/tvm/pull/11392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #11392: [IR] Renamed __VisitAttrs__ and __fvisit__ to non-reserved names

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11392:
URL: https://github.com/apache/tvm/pull/11392#issuecomment-1133335400

   Yeah, to the best of my knowledge, it's partly historical to define allowed outputs of name mangling, and partly to allow library implementations that might require namespace-ignoring macros.  Absent a string of bad luck, I don't think we'd have an accidental name collision, but I still like to avoid it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org