You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "gitgabrio (via GitHub)" <gi...@apache.org> on 2026/07/22 09:39:43 UTC
[PR] [incubator-kie-issues#2346] B-FEEL relational comparison expressions return false for non-boolean operands (#6770) [incubator-kie-drools]
gitgabrio opened a new pull request, #6820:
URL: https://github.com/apache/incubator-kie-drools/pull/6820
Cherry pick of
https://github.com/apache/incubator-kie-drools/pull/6770
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
**Thank you for submitting this pull request**
**NOTE!:** Double-check the target branch for this PR.
The default is `main` so it will target Drools 8 / Kogito.
**Ports** If a forward-port or a backport is needed, paste the forward port PR here
* [link](https://www.example.com)
**Issue**: _(please edit the GitHub Issues link if it exists)_
* [link](https://www.example.com)
**referenced Pull Requests**: _(please edit the URLs of referenced pullrequests if they exist)_
* paste the link(s) from GitHub here
* link 2
* link 3 etc.
<details>
<summary>
How to replicate CI configuration locally?
</summary>
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository.
[build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
</details>
<details>
<summary>
How to retest this PR or trigger a specific build:
</summary>
- for <b>pull request and downstream checks</b>
- Push a new commit to the PR. An empty commit would be enough.
- for a <b>full downstream build</b>
- for <b>github actions</b> job: add the label `run_fdb`
- for <b>Jenkins PR check only</b>
- If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2346] B-FEEL relational comparison expressions return false for non-boolean operands (#6770) [incubator-kie-drools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio closed pull request #6820: [incubator-kie-issues#2346] B-FEEL relational comparison expressions return false for non-boolean operands (#6770)
URL: https://github.com/apache/incubator-kie-drools/pull/6820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2346] B-FEEL relational comparison expressions return false for non-boolean operands (#6770) [incubator-kie-drools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #6820:
URL: https://github.com/apache/incubator-kie-drools/pull/6820#issuecomment-5057977461
That branch is too old to cherry pick this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues#2346] B-FEEL relational comparison expressions return false for non-boolean operands (#6770) [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6820:
URL: https://github.com/apache/incubator-kie-drools/pull/6820#issuecomment-5053432309
`Drools` GHA failed with:
```
2026-07-22T10:35:44.4576503Z [ERROR] Tests run: 10, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 0.048 s <<< FAILURE! -- in org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest
2026-07-22T10:35:44.4581685Z [ERROR] org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testMultiplication -- Time elapsed: 0.010 s <<< FAILURE!
2026-07-22T10:35:44.4583138Z org.opentest4j.AssertionFailedError:
2026-07-22T10:35:44.4583908Z
2026-07-22T10:35:44.4584215Z expected: 0S
2026-07-22T10:35:44.4584641Z but was: null
2026-07-22T10:35:44.4585709Z at org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testMultiplication(BFEELDialectHandlerTest.java:143)
2026-07-22T10:35:44.4587298Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2026-07-22T10:35:44.4588206Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4589098Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4589690Z
2026-07-22T10:35:44.4590764Z [ERROR] org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testDivision -- Time elapsed: 0.005 s <<< FAILURE!
2026-07-22T10:35:44.4592131Z org.opentest4j.AssertionFailedError:
2026-07-22T10:35:44.4592684Z
2026-07-22T10:35:44.4592998Z expected: 0
2026-07-22T10:35:44.4593514Z but was: null
2026-07-22T10:35:44.4594939Z at org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testDivision(BFEELDialectHandlerTest.java:179)
2026-07-22T10:35:44.4596334Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2026-07-22T10:35:44.4597284Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4598227Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4598860Z
2026-07-22T10:35:44.4599883Z [ERROR] org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testExponentiation -- Time elapsed: 0.002 s <<< FAILURE!
2026-07-22T10:35:44.4601260Z org.opentest4j.AssertionFailedError:
2026-07-22T10:35:44.4601716Z
2026-07-22T10:35:44.4601975Z expected: 8
2026-07-22T10:35:44.4602396Z but was: false
2026-07-22T10:35:44.4603464Z at org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testExponentiation(BFEELDialectHandlerTest.java:224)
2026-07-22T10:35:44.4604985Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2026-07-22T10:35:44.4605800Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4606606Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4607199Z
2026-07-22T10:35:44.4608435Z [ERROR] org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testAdditionWithPrecedenceOrder -- Time elapsed: 0.003 s <<< FAILURE!
2026-07-22T10:35:44.4609953Z org.opentest4j.AssertionFailedError:
2026-07-22T10:35:44.4610462Z
2026-07-22T10:35:44.4610756Z expected: 15
2026-07-22T10:35:44.4611251Z but was: null
2026-07-22T10:35:44.4612513Z at org.kie.dmn.feel.lang.ast.dialectHandlers.BFEELDialectHandlerTest.testAdditionWithPrecedenceOrder(BFEELDialectHandlerTest.java:82)
2026-07-22T10:35:44.4614289Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2026-07-22T10:35:44.4615193Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2026-07-22T10:35:44.4616066Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
```
because BFEELDialectHandlerTest contains tests which aren't covered by the original commit. You need to remove such tests or backport more fix commits.
---
`Kogito Downstream` GHA failures are caused by missing `999-SNAPSHOT` versions. I guess it has to use `10.2.999-SNAPSHOT` instead. Not related to this PR, but need to be fixed separately anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org