You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/28 14:59:58 UTC
[GitHub] [rocketmq] Stupid-Dird opened a new pull request #3677: Feature/3676
Stupid-Dird opened a new pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Issues #3676: handle the hook after the request () is sent
1. Use countdownlatch When await (), only onException () will countDown (), which will lead to timeout exceptions after successful transmission.
2. Solve the problem that the onsuccess () method of the incoming requestcallback is not called after sending successfully
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Stupid-Dird commented on pull request #3677: Feature/3676
Posted by GitBox <gi...@apache.org>.
Stupid-Dird commented on pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677#issuecomment-1002896454
Yes, you need to call countDown () in the onSuccess () method, but it is not just this problem, but also remove the RequestResponseFuture object in RequestFutureTable.
In the overloaded method, you need to call the onsuccess method of the incoming requestcallback. I have modified and initiated PR, and the link is as follows: https://github.com/apache/rocketmq/pull/3677
是的，需要在onSuccess()方法中调用countDown(),但不仅仅是这个问题，还有移除RequestFutureTable中的RequestResponseFuture对象。
在重载的方法中，需要对传入的RequestCallBack的onSuccess方法进行调用。我已经修改完成了发起了PR，链接如下：https://github.com/apache/rocketmq/pull/3677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Stupid-Dird commented on pull request #3677: Feature/3676
Posted by GitBox <gi...@apache.org>.
Stupid-Dird commented on pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677#issuecomment-1002896262
Yes, you need to call countDown () in the onSuccess () method, but it is not just this problem, but also remove the RequestResponseFuture object in RequestFutureTable.
In the overloaded method, you need to call the onsuccess method of the incoming requestcallback. I have modified and initiated PR, and the link is as follows: https://github.com/apache/rocketmq/pull/3677
是的，需要在onSuccess()方法中调用countDown(),但不仅仅是这个问题，还有移除RequestFutureTable中的RequestResponseFuture对象。
在重载的方法中，需要对传入的RequestCallBack的onSuccess方法进行调用。我已经修改完成了发起了PR，链接如下：https://github.com/apache/rocketmq/pull/3677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Stupid-Dird removed a comment on pull request #3677: Feature/3676
Posted by GitBox <gi...@apache.org>.
Stupid-Dird removed a comment on pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677#issuecomment-1002896262
Yes, you need to call countDown () in the onSuccess () method, but it is not just this problem, but also remove the RequestResponseFuture object in RequestFutureTable.
In the overloaded method, you need to call the onsuccess method of the incoming requestcallback. I have modified and initiated PR, and the link is as follows: https://github.com/apache/rocketmq/pull/3677
是的，需要在onSuccess()方法中调用countDown(),但不仅仅是这个问题，还有移除RequestFutureTable中的RequestResponseFuture对象。
在重载的方法中，需要对传入的RequestCallBack的onSuccess方法进行调用。我已经修改完成了发起了PR，链接如下：https://github.com/apache/rocketmq/pull/3677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Stupid-Dird closed pull request #3677: Feature/3676
Posted by GitBox <gi...@apache.org>.
Stupid-Dird closed pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Stupid-Dird removed a comment on pull request #3677: Feature/3676
Posted by GitBox <gi...@apache.org>.
Stupid-Dird removed a comment on pull request #3677:
URL: https://github.com/apache/rocketmq/pull/3677#issuecomment-1002896454
Yes, you need to call countDown () in the onSuccess () method, but it is not just this problem, but also remove the RequestResponseFuture object in RequestFutureTable.
In the overloaded method, you need to call the onsuccess method of the incoming requestcallback. I have modified and initiated PR, and the link is as follows: https://github.com/apache/rocketmq/pull/3677
是的，需要在onSuccess()方法中调用countDown(),但不仅仅是这个问题，还有移除RequestFutureTable中的RequestResponseFuture对象。
在重载的方法中，需要对传入的RequestCallBack的onSuccess方法进行调用。我已经修改完成了发起了PR，链接如下：https://github.com/apache/rocketmq/pull/3677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org