You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/20 00:21:57 UTC

[GitHub] srkukarni opened a new pull request #2616: Fixed the null checking of retryDetails field

srkukarni opened a new pull request #2616: Fixed the null checking of retryDetails field
URL: https://github.com/apache/incubator-pulsar/pull/2616
 
 
   ### Motivation
   
   In proto3, default value of a message field is not null but rather a default instance where all its members are set to default values recursively. This meant that our check for the existence of the field is not right.
   
   ### Modifications
   
   Describe the modifications you've done.
   
   ### Result
   
   After your change, what will change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services