[GitHub] [druid] a2l007 commented on a diff in pull request #11798: S3 Ingestion from non-default endpoints

[GitBox <gi...@apache.org>]

a2l007 commented on code in PR #11798:
URL: https://github.com/apache/druid/pull/11798#discussion_r918148630


##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java:
##########
@@ -98,16 +109,49 @@ public S3InputSource(
       @JsonProperty("objects") @Nullable List<CloudObjectLocation> objects,
       @JsonProperty("filter") @Nullable String filter,
       @JsonProperty("properties") @Nullable S3InputSourceConfig s3InputSourceConfig,
+      @JsonProperty("proxyConfig") @Nullable AWSProxyConfig awsProxyConfig,
+      @JsonProperty("endpointConfig") @Nullable AWSEndpointConfig awsEndpointConfig,
+      @JsonProperty("clientConfig") @Nullable AWSClientConfig awsClientConfig,

Review Comment:
   Reusing the Config objects here so that we don't duplicate the properties. We could push these under `S3InputSourceConfig` itself if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org