You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/31 23:51:23 UTC
[PR] test(amber): cover computing unit worker args [texera]
aglinxinyuan opened a new pull request, #7192:
URL: https://github.com/apache/texera/pull/7192
### What changes were proposed in this PR?
Adds focused unit coverage for computing-unit worker command-line parsing, including empty input, repeated addresses, and malformed options.
### Any related issues, documentation, discussions?
Closes #7189
### How was this PR tested?
- `WorkflowExecutionService/testOnly org.apache.texera.web.ComputingUnitWorkerSpec` — 5 passed.
- `WorkflowExecutionService/Test/scalafmtAll` and `WorkflowExecutionService/Test/scalafix`
- `WorkflowExecutionService/Test/scalafmtCheck` and `WorkflowExecutionService/Test/scalafix --check`
Mutation proof (each production change was reverted):
| Production mutation | Focused test result |
| --- | --- |
| Renamed the recognized `--serverAddr` option | 2 failed |
| Changed the parsed option key | 2 failed |
| Skipped malformed-option rejection | 2 failed |
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): cover computing unit worker args [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7192:
URL: https://github.com/apache/texera/pull/7192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): cover computing unit worker args [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7192:
URL: https://github.com/apache/texera/pull/7192#issuecomment-5148414577
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): cover computing unit worker args [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7192:
URL: https://github.com/apache/texera/pull/7192#issuecomment-5148623797
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7192?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.74%. Comparing base ([`2388b85`](https://app.codecov.io/gh/apache/texera/commit/2388b8573836f3f1a84aa808ed7b3a999e3626bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ca65e1b`](https://app.codecov.io/gh/apache/texera/commit/ca65e1bacfaa0f870d724b033787c6a95ffac945?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7192 +/- ##
============================================
+ Coverage 80.73% 80.74% +0.01%
+ Complexity 3925 3924 -1
============================================
Files 1162 1160 -2
Lines 46264 45934 -330
Branches 5153 5118 -35
============================================
- Hits 37350 37089 -261
+ Misses 7243 7180 -63
+ Partials 1671 1665 -6
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.42% <ø> (ø)` | | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.05% <ø> (+0.04%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.62% <ø> (-0.36%)` | :arrow_down: | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.59% <ø> (-0.22%)` | :arrow_down: | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.25% <ø> (+0.02%)` | :arrow_up: | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.69% <ø> (-0.20%)` | :arrow_down: | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.36% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [ebfd1db](https://app.codecov.io/gh/apache/texera/commit/ebfd1db5f9c8c427a406cf09318e7012436edbde?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7192?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): cover computing unit worker args [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7192:
URL: https://github.com/apache/texera/pull/7192#issuecomment-5148437209
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 1 better · 🔴 6 worse · ⚪ 8 noise (<±5%) · 0 without baseline
> Compared against main `0783470` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30674006127)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 439 | 0.268 | 21,329/31,641/31,641 us | 🔴 +16.3% / 🔴 +95.3% |
| 🔴 | bs=100 sw=10 sl=64 | 905 | 0.552 | 103,981/155,837/155,837 us | 🔴 +23.2% / 🔴 +40.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,077 | 0.657 | 927,611/980,938/980,938 us | ⚪ within ±5% / 🟢 -9.4% |
<details><summary>Baseline details</summary>
Latest main `0783470` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 439 tuples/sec | 456 tuples/sec | 765.25 tuples/sec | -3.7% | -42.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.268 MB/s | 0.278 MB/s | 0.467 MB/s | -3.6% | -42.6% |
| bs=10 sw=10 sl=64 | p50 | 21,329 us | 22,870 us | 12,703 us | -6.7% | +67.9% |
| bs=10 sw=10 sl=64 | p95 | 31,641 us | 27,212 us | 16,199 us | +16.3% | +95.3% |
| bs=10 sw=10 sl=64 | p99 | 31,641 us | 27,212 us | 19,557 us | +16.3% | +61.8% |
| bs=100 sw=10 sl=64 | throughput | 905 tuples/sec | 963 tuples/sec | 965.22 tuples/sec | -6.0% | -6.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.552 MB/s | 0.588 MB/s | 0.589 MB/s | -6.1% | -6.3% |
| bs=100 sw=10 sl=64 | p50 | 103,981 us | 100,065 us | 103,830 us | +3.9% | +0.1% |
| bs=100 sw=10 sl=64 | p95 | 155,837 us | 126,501 us | 110,778 us | +23.2% | +40.7% |
| bs=100 sw=10 sl=64 | p99 | 155,837 us | 126,501 us | 118,713 us | +23.2% | +31.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,077 tuples/sec | 1,086 tuples/sec | 992.33 tuples/sec | -0.8% | +8.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.657 MB/s | 0.663 MB/s | 0.606 MB/s | -0.9% | +8.5% |
| bs=1000 sw=10 sl=64 | p50 | 927,611 us | 920,254 us | 1,016,959 us | +0.8% | -8.8% |
| bs=1000 sw=10 sl=64 | p95 | 980,938 us | 961,089 us | 1,062,501 us | +2.1% | -7.7% |
| bs=1000 sw=10 sl=64 | p99 | 980,938 us | 961,089 us | 1,082,611 us | +2.1% | -9.4% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,455.96,200,128000,439,0.268,21329.47,31640.88,31640.88
1,100,10,64,20,2209.70,2000,1280000,905,0.552,103980.70,155836.82,155836.82
2,1000,10,64,20,18575.69,20000,12800000,1077,0.657,927611.08,980937.76,980937.76
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org