[GitHub] [incubator-superset] villebro commented on a change in pull request #9943: style(mypy): Enforcing typing for superset module

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#discussion_r434178282



##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
             d["columns"] = gb
         return d
 
-    def get_js_columns(self, d):
+    def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:

Review comment:
       `d` looks like a bad variable name. I thought these were forbidden in `.pylintrc`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org