You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/24 09:56:16 UTC
[GitHub] [flink] Myracle opened a new pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Myracle opened a new pull request #13227:
URL: https://github.com/apache/flink/pull/13227
## What is the purpose of the change
*Flink fails to archiveExecutionGraph sometimes. Currently, the MiniDispatcher is stopped at once after sending cancel command. So job may be removed by MiniDispatcher before it reaches globally terminal state and archiveExecutionGraph will not be executed. It is related to [FLINK-15116](https://issues.apache.org/jira/browse/FLINK-15116). So we try to revert the change in MiniDispatcher.*
## Brief change log
- *Revert the change in MiniDispatcher caused by [FLINK-15116](https://issues.apache.org/jira/browse/FLINK-15116).*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
* 160a51baaf35f77f30c65ce358116446c007d4f3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679031996
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 17b779c8ed6e12edd9f6da41860a1b52c8a8390c (Mon Aug 24 09:58:02 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18959).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 160a51baaf35f77f30c65ce358116446c007d4f3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 160a51baaf35f77f30c65ce358116446c007d4f3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124)
* 8660a6afddeee3483e5e57581335966f93578219 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8660a6afddeee3483e5e57581335966f93578219 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13227:
URL: https://github.com/apache/flink/pull/13227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679832482
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
}, {
"hash" : "a439269835304a2a64316bcc6779c8997ba4716d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6159",
"triggerID" : "a439269835304a2a64316bcc6779c8997ba4716d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a439269835304a2a64316bcc6779c8997ba4716d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6159)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
* 160a51baaf35f77f30c65ce358116446c007d4f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
}, {
"hash" : "a439269835304a2a64316bcc6779c8997ba4716d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6159",
"triggerID" : "a439269835304a2a64316bcc6779c8997ba4716d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8660a6afddeee3483e5e57581335966f93578219 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141)
* a439269835304a2a64316bcc6779c8997ba4716d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6159)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13227:
URL: https://github.com/apache/flink/pull/13227#discussion_r481852784
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -91,37 +91,21 @@ public MiniDispatcher(
ApplicationStatus status = result.getSerializedThrowable().isPresent() ?
ApplicationStatus.FAILED : ApplicationStatus.SUCCEEDED;
- LOG.debug("Shutting down per-job cluster because someone retrieved the job result.");
+ LOG.debug("Shutting down cluster because someone retrieved the job result.");
shutDownFuture.complete(status);
});
} else {
- LOG.debug("Not shutting down per-job cluster after someone retrieved the job result.");
+ LOG.debug("Not shutting down cluster after someone retrieved the job result.");
}
return jobResultFuture;
}
- @Override
- public CompletableFuture<Acknowledge> cancelJob(
- JobID jobId, Time timeout) {
- CompletableFuture<Acknowledge> cancelFuture = super.cancelJob(jobId, timeout);
-
- cancelFuture.thenAccept((ignored) -> {
- LOG.debug("Shutting down per-job cluster because the job was canceled.");
- shutDownFuture.complete(ApplicationStatus.CANCELED);
- });
-
- return cancelFuture;
- }
-
@Override
protected void jobReachedGloballyTerminalState(ArchivedExecutionGraph archivedExecutionGraph) {
super.jobReachedGloballyTerminalState(archivedExecutionGraph);
- if (executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
- // shut down since we don't have to wait for the execution result retrieval
- shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
- }
+ shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
Review comment:
I would suggest to add a field which stores whether `cancelJob` has been called. If this is the case or if `executionMode == ClusterEntrypoint.ExecutionMode.DETACHED`, then we complete the shut down future. It would also be great to add a test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 160a51baaf35f77f30c65ce358116446c007d4f3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124)
* 8660a6afddeee3483e5e57581335966f93578219 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13227:
URL: https://github.com/apache/flink/pull/13227#discussion_r478315423
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -91,37 +91,21 @@ public MiniDispatcher(
ApplicationStatus status = result.getSerializedThrowable().isPresent() ?
ApplicationStatus.FAILED : ApplicationStatus.SUCCEEDED;
- LOG.debug("Shutting down per-job cluster because someone retrieved the job result.");
+ LOG.debug("Shutting down cluster because someone retrieved the job result.");
shutDownFuture.complete(status);
});
} else {
- LOG.debug("Not shutting down per-job cluster after someone retrieved the job result.");
+ LOG.debug("Not shutting down cluster after someone retrieved the job result.");
}
return jobResultFuture;
}
- @Override
- public CompletableFuture<Acknowledge> cancelJob(
- JobID jobId, Time timeout) {
- CompletableFuture<Acknowledge> cancelFuture = super.cancelJob(jobId, timeout);
-
- cancelFuture.thenAccept((ignored) -> {
- LOG.debug("Shutting down per-job cluster because the job was canceled.");
- shutDownFuture.complete(ApplicationStatus.CANCELED);
- });
-
- return cancelFuture;
- }
-
@Override
protected void jobReachedGloballyTerminalState(ArchivedExecutionGraph archivedExecutionGraph) {
super.jobReachedGloballyTerminalState(archivedExecutionGraph);
- if (executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
- // shut down since we don't have to wait for the execution result retrieval
- shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
- }
+ shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
Review comment:
I think we cannot do this unconditionally because we want to serve the job result in case of a successful execution of the job when using the attached mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on a change in pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
Myracle commented on a change in pull request #13227:
URL: https://github.com/apache/flink/pull/13227#discussion_r481069951
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -91,37 +91,21 @@ public MiniDispatcher(
ApplicationStatus status = result.getSerializedThrowable().isPresent() ?
ApplicationStatus.FAILED : ApplicationStatus.SUCCEEDED;
- LOG.debug("Shutting down per-job cluster because someone retrieved the job result.");
+ LOG.debug("Shutting down cluster because someone retrieved the job result.");
shutDownFuture.complete(status);
});
} else {
- LOG.debug("Not shutting down per-job cluster after someone retrieved the job result.");
+ LOG.debug("Not shutting down cluster after someone retrieved the job result.");
}
return jobResultFuture;
}
- @Override
- public CompletableFuture<Acknowledge> cancelJob(
- JobID jobId, Time timeout) {
- CompletableFuture<Acknowledge> cancelFuture = super.cancelJob(jobId, timeout);
-
- cancelFuture.thenAccept((ignored) -> {
- LOG.debug("Shutting down per-job cluster because the job was canceled.");
- shutDownFuture.complete(ApplicationStatus.CANCELED);
- });
-
- return cancelFuture;
- }
-
@Override
protected void jobReachedGloballyTerminalState(ArchivedExecutionGraph archivedExecutionGraph) {
super.jobReachedGloballyTerminalState(archivedExecutionGraph);
- if (executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
- // shut down since we don't have to wait for the execution result retrieval
- shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
- }
+ shutDownFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
Review comment:
@tillrohrmann You are right. We should not shutdown dispatcher here if job result is required. But if we just do nothing here for the attached mode, the dispatcher may be not shutdown at last. Imagine that the client is shutdown unexpectedly, then the job is cancelled from web. In this case, no job request is made so that the dispatcher will not be shutdown. Maybe we should make our best to shutdown dispatcher after some time for the attached mode. What do you think? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-686435806
Thanks for the suggestions and all the help, @tillrohrmann . The tests are all passed. Expect to merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817)
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817)
* 213695b1635186819bcde49ed3c94f0238943ee2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13227: [FLINK-18959][Runtime] Try to revert MiniDispatcher for archiveExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5817",
"triggerID" : "17b779c8ed6e12edd9f6da41860a1b52c8a8390c",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "213695b1635186819bcde49ed3c94f0238943ee2",
"triggerType" : "PUSH"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5841",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "213695b1635186819bcde49ed3c94f0238943ee2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5838",
"triggerID" : "679832482",
"triggerType" : "MANUAL"
}, {
"hash" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6124",
"triggerID" : "160a51baaf35f77f30c65ce358116446c007d4f3",
"triggerType" : "PUSH"
}, {
"hash" : "8660a6afddeee3483e5e57581335966f93578219",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141",
"triggerID" : "8660a6afddeee3483e5e57581335966f93578219",
"triggerType" : "PUSH"
}, {
"hash" : "a439269835304a2a64316bcc6779c8997ba4716d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a439269835304a2a64316bcc6779c8997ba4716d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8660a6afddeee3483e5e57581335966f93578219 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6141)
* a439269835304a2a64316bcc6779c8997ba4716d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org