You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/04/26 04:17:50 UTC
[jira] Created: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
IPC doesn't properly handle IOEs thrown by socket factory
---------------------------------------------------------
Key: HADOOP-6724
URL: https://issues.apache.org/jira/browse/HADOOP-6724
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 0.20.3, 0.21.0, 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861235#action_12861235 ]
Tom White commented on HADOOP-6724:
-----------------------------------
+1 (Nice Mockito test.)
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6724:
--------------------------------
Attachment: hadoop-6724-20-1.patch
Patch for 20 attached.
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.21.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HADOOP-6724.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
0.20.3
I ran test-patch and committed this to branch 20.
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.20.3, 0.22.0, 0.21.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reopened HADOOP-6724:
---------------------------------
Think we should commit this to branch-20 as well. It's pretty nasty and a simple fix.
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.21.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6724:
--------------------------------
Attachment: hadoop-6724.txt
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925163#action_12925163 ]
Eli Collins commented on HADOOP-6724:
-------------------------------------
Because it was already committed to the 21 branch.
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.20.3, 0.21.0, 0.22.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6724:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: 0.22.0
Resolution: Fixed
I've just committed this. Thanks Todd!
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860785#action_12860785 ]
Hadoop QA commented on HADOOP-6724:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442801/hadoop-6724.txt
against trunk revision 937881.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/console
This message is automatically generated.
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HADOOP-6724:
-------------------------------------
Fix Version/s: 0.21.0
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.21.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6724:
--------------------------------
Status: Patch Available (was: Open)
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6724) IPC doesn't properly handle IOEs
thrown by socket factory
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925101#action_12925101 ]
Owen O'Malley commented on HADOOP-6724:
---------------------------------------
Why didn't you apply this to 0.21?
> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
> Key: HADOOP-6724
> URL: https://issues.apache.org/jira/browse/HADOOP-6724
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.3, 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.20.3, 0.21.0, 0.22.0
>
> Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.