[GitHub] [incubator-nuttx] patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

[GitBox <gi...@apache.org>]

patacongo commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY
URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-593465989
 
 
   The frequency is only hardcoded if CONFIG_SUPPRESS_CLOCK_CONFIG is selected.
   
   That is because the actual clock configuration logic is (or at least was) proprietary and Expressif never released this in source form, only as a binary library.  If that library is downloaded and included in the build, then you can select any of the supported frequencies.
   
   I don't follow ESP32 closely, but this change does not look correct and I do not think that it should be incorporated.
   
   You should also look at TizenRT.  Expressif took the NuttX ESP32 port and extended it in Tizen RT.  You can bring those improvements in as you see fit, provided that we make sure that the Apache licensing is correct.  See https://github.com/Samsung/TizenRT/tree/master/os/arch/xtensa.
   
   Since that code is supported by Expressif, that should be considered an authoritative source.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services