[jira] [Resolved] (SLING-4735) New tests for commons.scheduler module

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz resolved SLING-4735.
----------------------------------------

Thanks very much, I have committed your tests in http://svn.apache.org/r1682221 - please cross-check. I made minor changes to the pom to avoid snapshots and avoid depending on maven-scm-client which is not needed AFAICS.

I have also improved the WebConsolePrinterTest in http://svn.apache.org/r1682225 to use less fragile regular expressions matching. Please use this technique where appropriate in the future, as exact matches are more likely to break if behavior changes just slightly in the future.

Test coverage is good now, marking this fixed.

Note that you can overwrite jira attachments by re-uploading a file with the same name, that's useful if you revise your patches as we go.

> New tests for commons.scheduler module
> --------------------------------------
>
>                 Key: SLING-4735
>                 URL: https://issues.apache.org/jira/browse/SLING-4735
>             Project: Sling
>          Issue Type: Test
>          Components: Commons
>            Reporter: Petr Shypila
>            Assignee: Petr Shypila
>            Priority: Minor
>              Labels: gsoc2015
>         Attachments: week0-commons-scheduler-tests.patch, week0-ver2.patch
>
>
> In scope of this issue I should cover commons.scheduler module with unit and integration tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)