[jira] [Commented] (FLINK-24167) Split HeartbeatTarget to HeartbeatReceiver and HeartbeatSender

["Till Rohrmann (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-24167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423224#comment-17423224 ] 

Till Rohrmann commented on FLINK-24167:
---------------------------------------

Splitting the interface will probably cause quite some changes in the {{HeartbeatManager}} implementations and the {{HeartbeatMonitor}}. But what we could easily do is to let {{HeartbeatReceiver}} extend {{HeartbeatTarget}} and add a default implementation for {{requestHeartbeat}} that fails and the same for {{HeartbeatSender}}. What do you think?

> Split HeartbeatTarget to HeartbeatReceiver and HeartbeatSender 
> ---------------------------------------------------------------
>
>                 Key: FLINK-24167
>                 URL: https://issues.apache.org/jira/browse/FLINK-24167
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Aitozi
>            Priority: Minor
>
> Currently, {{HeartbeatTarget}} is responsible for the {{receiveHeartbeat}} and {{requestHeartbeat}}. But many components just need one of them and let the not needed interface implements with {{unsupportedOperationFuture}}. This makes the implementation not so clear. Can we split the {{HeartbeatTarget}} to {{HeartbeatReceiver}} and {{HeartbeatSender}}.
> The  {{HeartbeatReceiver}} only cares about the logic when receive a heartbeat.
> The  {{HeartbeatSender}} only cares about the logic of send heartbeat.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)