You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/11 07:41:41 UTC
[GitHub] codecov-io commented on issue #4593: [sql lab] reduce the number of metadata calls when loading a table
codecov-io commented on issue #4593: [sql lab] reduce the number of metadata calls when loading a table
URL: https://github.com/apache/incubator-superset/pull/4593#issuecomment-372095936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=h1) Report
> Merging [#4593](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f9881101ee9cd447f7ccb2d38bc7563f31f686c5?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `90%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4593 +/- ##
==========================================
- Coverage 71.17% 71.14% -0.03%
==========================================
Files 188 188
Lines 14834 14835 +1
Branches 1086 1086
==========================================
- Hits 10558 10555 -3
- Misses 4273 4277 +4
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.7% <0%> (?)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `51.53% <100%> (-0.73%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4593/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.22% <100%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=footer). Last update [f988110...6498e8b](https://codecov.io/gh/apache/incubator-superset/pull/4593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services