You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@batchee.apache.org by Mark Struberg <st...@yahoo.de> on 2014/03/30 11:06:28 UTC
OpenEJBJobOperatorClassLoaderFinder
This gets a -1 from me.
>From the docs:
// simple impl taking just *the* other app if tomee deploys a single application
// or a specific one if you specifiy in properties batchee.application
This does not work with _any_ other server.
This does not work if there are more than 1 webapp.
This does not even work in the standard TomEE installation as there are default apps already installed.
We simply cannot do this. I agree with you that we need a way to start jobs from another app, but imo we should think hard to find a more generic solution as already noted in BATCHEE-16
A 'naked' BatchEE WAR does imo not make much sense _at the moment_. And if so, we can only _read_ the status from the DB and not start batches, etc.
There are 2 use cases which work perfectly fine atm:
1.) standalone batch job using CLI (self made with DeltaSpike CdiCtrl, need to test our new batchee-cli module yet)
2.) a Batch WAR which contains the batchee-servlet and all the Batches I have in my application.
All other use cases needs a clean idea still.
LieGrue,
strub
Re: OpenEJBJobOperatorClassLoaderFinder
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Thats why it was a spi ;)... But well remove it so no need to keep this
thread up i guess.
Le 30 mars 2014 10:49, "Mark Struberg" <st...@yahoo.de> a écrit :
> I think it's good to have it working in TomEE and if there is a need for
> 'connectors' we should add them. Especially since we should do integration
> tests against a container.
> But I'm against features which really _only_ work in TomEE. The stuff we
> do here should work on as many containers as possible.
>
> LieGrue,
> strub
>
>
>
>
>
> On Sunday, 30 March 2014, 11:25, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> First let me say I'm ok to remove it.
> >
> >But about your points:
> >
> >1) work only with openejb/tomee: true like some other parts of batchee
> >which are not portable, that's a feature so not a big deal IMO
> >2) doesnt work with more than one app, false works with as much app as
> >you want since you select the app
> >3) doesnt work in default tomee: you think to docs, manager etc? see 2
> >+ often default tomee comes from tomee maven plugin where these apps
> >are not here by default
> >
> >The only generic solution will be to able to locate an app from a name
> >or a marker...that's this impl.
> >
> >About valid cases:
> >
> >1) yes
> >2) yes
> >3) jaxrs cases
> >4) custom spi of (jobxmlloader and artifactfactory) or (servicelocator)
> >
> >BTW if you don't do it before me i'll remove it tonight or tomorrow
> morning
> >
> >++
> >Romain Manni-Bucau
> >Twitter: @rmannibucau
> >Blog: http://rmannibucau.wordpress.com/
> >LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >Github: https://github.com/rmannibucau
> >
> >
> >
> >
> >2014-03-30 11:06 GMT+02:00 Mark Struberg <st...@yahoo.de>:
> >> This gets a -1 from me.
> >>
> >> From the docs:
> >> // simple impl taking just *the* other app if tomee deploys a single
> application
> >> // or a specific one if you specifiy in properties batchee.application
> >>
> >> This does not work with _any_ other server.
> >> This does not work if there are more than 1 webapp.
> >> This does not even work in the standard TomEE installation as there are
> default apps already installed.
> >>
> >> We simply cannot do this. I agree with you that we need a way to start
> jobs from another app, but imo we should think hard to find a more generic
> solution as already noted in BATCHEE-16
> >>
> >> A 'naked' BatchEE WAR does imo not make much sense _at the moment_. And
> if so, we can only _read_ the status from the DB and not start batches, etc.
> >>
> >>
> >> There are 2 use cases which work perfectly fine atm:
> >>
> >> 1.) standalone batch job using CLI (self made with DeltaSpike CdiCtrl,
> need to test our new batchee-cli module yet)
> >> 2.) a Batch WAR which contains the batchee-servlet and all the Batches
> I have in my application.
> >> All other use cases needs a clean idea still.
> >>
> >> LieGrue,
> >> strub
> >
> >
> >
Re: OpenEJBJobOperatorClassLoaderFinder
Posted by Mark Struberg <st...@yahoo.de>.
I think it's good to have it working in TomEE and if there is a need for 'connectors' we should add them. Especially since we should do integration tests against a container.
But I'm against features which really _only_ work in TomEE. The stuff we do here should work on as many containers as possible.
LieGrue,
strub
On Sunday, 30 March 2014, 11:25, Romain Manni-Bucau <rm...@gmail.com> wrote:
First let me say I'm ok to remove it.
>
>But about your points:
>
>1) work only with openejb/tomee: true like some other parts of batchee
>which are not portable, that's a feature so not a big deal IMO
>2) doesnt work with more than one app, false works with as much app as
>you want since you select the app
>3) doesnt work in default tomee: you think to docs, manager etc? see 2
>+ often default tomee comes from tomee maven plugin where these apps
>are not here by default
>
>The only generic solution will be to able to locate an app from a name
>or a marker...that's this impl.
>
>About valid cases:
>
>1) yes
>2) yes
>3) jaxrs cases
>4) custom spi of (jobxmlloader and artifactfactory) or (servicelocator)
>
>BTW if you don't do it before me i'll remove it tonight or tomorrow morning
>
>++
>Romain Manni-Bucau
>Twitter: @rmannibucau
>Blog: http://rmannibucau.wordpress.com/
>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>Github: https://github.com/rmannibucau
>
>
>
>
>2014-03-30 11:06 GMT+02:00 Mark Struberg <st...@yahoo.de>:
>> This gets a -1 from me.
>>
>> From the docs:
>> // simple impl taking just *the* other app if tomee deploys a single application
>> // or a specific one if you specifiy in properties batchee.application
>>
>> This does not work with _any_ other server.
>> This does not work if there are more than 1 webapp.
>> This does not even work in the standard TomEE installation as there are default apps already installed.
>>
>> We simply cannot do this. I agree with you that we need a way to start jobs from another app, but imo we should think hard to find a more generic solution as already noted in BATCHEE-16
>>
>> A 'naked' BatchEE WAR does imo not make much sense _at the moment_. And if so, we can only _read_ the status from the DB and not start batches, etc.
>>
>>
>> There are 2 use cases which work perfectly fine atm:
>>
>> 1.) standalone batch job using CLI (self made with DeltaSpike CdiCtrl, need to test our new batchee-cli module yet)
>> 2.) a Batch WAR which contains the batchee-servlet and all the Batches I have in my application.
>> All other use cases needs a clean idea still.
>>
>> LieGrue,
>> strub
>
>
>
Re: OpenEJBJobOperatorClassLoaderFinder
Posted by Romain Manni-Bucau <rm...@gmail.com>.
First let me say I'm ok to remove it.
But about your points:
1) work only with openejb/tomee: true like some other parts of batchee
which are not portable, that's a feature so not a big deal IMO
2) doesnt work with more than one app, false works with as much app as
you want since you select the app
3) doesnt work in default tomee: you think to docs, manager etc? see 2
+ often default tomee comes from tomee maven plugin where these apps
are not here by default
The only generic solution will be to able to locate an app from a name
or a marker...that's this impl.
About valid cases:
1) yes
2) yes
3) jaxrs cases
4) custom spi of (jobxmlloader and artifactfactory) or (servicelocator)
BTW if you don't do it before me i'll remove it tonight or tomorrow morning
++
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-03-30 11:06 GMT+02:00 Mark Struberg <st...@yahoo.de>:
> This gets a -1 from me.
>
> From the docs:
> // simple impl taking just *the* other app if tomee deploys a single application
> // or a specific one if you specifiy in properties batchee.application
>
> This does not work with _any_ other server.
> This does not work if there are more than 1 webapp.
> This does not even work in the standard TomEE installation as there are default apps already installed.
>
> We simply cannot do this. I agree with you that we need a way to start jobs from another app, but imo we should think hard to find a more generic solution as already noted in BATCHEE-16
>
> A 'naked' BatchEE WAR does imo not make much sense _at the moment_. And if so, we can only _read_ the status from the DB and not start batches, etc.
>
>
> There are 2 use cases which work perfectly fine atm:
>
> 1.) standalone batch job using CLI (self made with DeltaSpike CdiCtrl, need to test our new batchee-cli module yet)
> 2.) a Batch WAR which contains the batchee-servlet and all the Batches I have in my application.
> All other use cases needs a clean idea still.
>
> LieGrue,
> strub