You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 15:31:36 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
nealrichardson opened a new pull request #11109:
URL: https://github.com/apache/arrow/pull/11109
This was made trivial to do by ARROW-12981. Also includes ARROW-13586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#issuecomment-916065138
Revision: 36a67c8c27d60cd9ab332757ba1f9fe6cb5c99e1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-837](https://github.com/ursacomputing/crossbow/branches/all?query=actions-837)
|Task|Status|
|----|------|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-837-azure-test-r-minimal-build)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-837-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#issuecomment-916064481
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos7-devtoolset-8 test-r-minimal-build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#discussion_r704812737
##########
File path: r/tools/nixlibs.R
##########
@@ -423,13 +423,14 @@ cmake_version <- function(cmd = "cmake") {
)
}
-turn_off_thirdparty_features <- function(env_var_list) {
+turn_off_optional_features <- function(env_var_list) {
Review comment:
This is probably just 🚲 🏠 ing, but I wonder if we should name this `turn_off_all_optional_features()` so it's clear that we intend everything optional be be disabled, and we're not picking and choosing some (like we do elsewhere in this script)
##########
File path: r/tools/nixlibs.R
##########
@@ -203,10 +203,6 @@ system_release <- function() {
read_system_release <- function() utils::head(readLines("/etc/system-release"), 1)
-is_solaris <- function() {
- tolower(Sys.info()[["sysname"]]) %in% "sunos"
-}
-
Review comment:
It is a bit "wasteful" since we only use it in one location, but I appreciate that `is_solaris()` is clearer what is going on with this function. Unless the intention is to make this a little obfuscated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11109:
URL: https://github.com/apache/arrow/pull/11109#issuecomment-915343562
https://issues.apache.org/jira/browse/ARROW-11885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11109: ARROW-11885: [R] Turn off some capabilities when LIBARROW_MINIMAL=true
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11109:
URL: https://github.com/apache/arrow/pull/11109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org