You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/06 00:25:15 UTC
Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
Changes the logrotate container logger to use the default `environment` for `subprocess`.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
Diff: https://reviews.apache.org/r/43272/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/#review118152
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43260, 43261, 43271, 43272]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 11:25 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43272/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 11:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
>
>
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
> Changes the logrotate container logger to use the default `environment` for `subprocess`.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
> src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
> src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
>
> Diff: https://reviews.apache.org/r/43272/diff/
>
>
> Testing
> -------
>
> make check (OSX)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/#review119754
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43260, 43261, 43271, 43272]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 18, 2016, 7:22 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43272/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 7:22 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
>
>
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
> Changes the logrotate container logger to use the default `environment` for `subprocess`.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0
> src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
> src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
>
> Diff: https://reviews.apache.org/r/43272/diff/
>
>
> Testing
> -------
>
> make check (OSX)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/#review120015
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43260, 43261, 43271, 43272]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 7:48 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43272/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
>
>
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
> Changes the logrotate container logger to use the default `environment` for `subprocess`.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0
> src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
> src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
>
> Diff: https://reviews.apache.org/r/43272/diff/
>
>
> Testing
> -------
>
> sudo make check
>
> | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
> Non-SSL | :) | :) | x | X_X | :) | :) | :) |
> With-SSL | | :) | x | & | * | * | :) |
>
> :) = Passed.
> X_X = Test suite exited prematurely (flaky test -> segfault).
>
> Note: These are known flaky tests.
> x = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
> & = DockerContainerizerTest.ROOT_DOCKER_Recover
> * = DockerContainerizerTest.ROOT_DOCKER_Logs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 11:48 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
Added CI test results.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
Changes the logrotate container logger to use the default `environment` for `subprocess`.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
Diff: https://reviews.apache.org/r/43272/diff/
Testing (updated)
-------
sudo make check
| OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
Non-SSL | :) | :) | x | X_X | :) | :) | :) |
With-SSL | | :) | x | & | * | * | :) |
:) = Passed.
X_X = Test suite exited prematurely (flaky test -> segfault).
Note: These are known flaky tests.
x = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
& = DockerContainerizerTest.ROOT_DOCKER_Recover
* = DockerContainerizerTest.ROOT_DOCKER_Logs
Thanks,
Joseph Wu
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 10:54 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
Made `subprocess_environment` a private (static) function.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
Changes the logrotate container logger to use the default `environment` for `subprocess`.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
Diff: https://reviews.apache.org/r/43272/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu
Re: Review Request 43272: Modify the containerizer, fetcher,
and container logger's environment.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 11:22 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
Rebase and address conflict with Subprocess Hooks/Options.
Bugs: MESOS-4609
https://issues.apache.org/jira/browse/MESOS-4609
Repository: mesos
Description
-------
Delegates some of the environment logic in the containerizer and fetcher to the `subprocess_environment` helper.
Changes the logrotate container logger to use the default `environment` for `subprocess`.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
Diff: https://reviews.apache.org/r/43272/diff/
Testing
-------
make check (OSX)
Thanks,
Joseph Wu