[GitHub] [incubator-pagespeed-mod] Lofesa edited a comment on issue #1899: data-srcset in img and amp-img

[GitBox <gi...@apache.org>]

Lofesa edited a comment on issue #1899: data-srcset in img and amp-img
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-508834228
 
 
   @oschaaf  Well... out of the loop we need 2 `if` and we need to not ask for and img element as in the original image_rewrite_filter.cc file (line 2141) cause not only img elements can have srcset/data-srcset.
   Maybe we change the line 2141 w/ some like this:
   `if (element->keyword() == semantic_type::kImage) {`
   before asking for srcset/data-srcset attributes?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services