[GitHub] [spark] laflechejonathan commented on pull request #29888: [SPARK-33012][BUILD][K8S] Upgrade fabric8 to 4.10.3

[GitBox <gi...@apache.org>]

laflechejonathan commented on pull request #29888:
URL: https://github.com/apache/spark/pull/29888#issuecomment-701281802


   I believe I've addressed your comments, thank you for the quick review!
   
   @dongjoon-hyun, to answer your questions:
   
   1. Done!
   2. We are running against k8s 1.18.8
   3. Correct, in spite of the declared compatibility, spark appears to run fine against k8s 1.18.x. That said, in our other java projects that rely on `kubernetes-client`, we routinely encounter subtle breaks and behaviour changes as we upgrade, so would like to keep spark as up to date as possible, so when break does occur, the version delta is smaller and less risky.
   
   On the integration test failure, I'm fairly certain it's a flake. We used to run into this error when launching spark applications in production, and had to add functionality to block spark-submit until the service account token is created for a namespace. Would be good to add similar functionality to solve this flake, but should be out of scope of this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org