[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2637: [GOBBLIN-772]Implement Schema Comparison Strategy during Disctp

[GitBox <gi...@apache.org>]

jhsenjaliya commented on a change in pull request #2637: [GOBBLIN-772]Implement Schema Comparison Strategy during Disctp
URL: https://github.com/apache/incubator-gobblin/pull/2637#discussion_r285431587
 
 

 ##########
 File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/extractor/FileAwareInputStreamExtractorWithCheckSchema.java
 ##########
 @@ -39,32 +43,38 @@
  * check if the schema matches the expected schema. If not it will abort the job.
  */
 
-public class FileAwareInputStreamExtractorWithCheckSchema extends FileAwareInputStreamExtractor{
+public class FileAwareInputStreamExtractorWithCheckSchema extends FileAwareInputStreamExtractor {
 
 Review comment:
   just a comment on this class: i understand that this class already exists and its adding proper field level schema check, but can schemaCheck not be part of `FileAwareInputStreamExtractor` itself instead of introducing another class for schemaCheck functionality, since that is the only difference with this class which probably can be controlled by a schemaCheck flag. may be its a separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services