You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2010/06/16 22:44:22 UTC
[jira] Created: (TAP5-1190) New page-level events to "decorate"
component event and page render links
New page-level events to "decorate" component event and page render links
-------------------------------------------------------------------------
Key: TAP5-1190
URL: https://issues.apache.org/jira/browse/TAP5-1190
Project: Tapestry 5
Issue Type: New Feature
Components: tapestry-core
Affects Versions: 5.2.0
Reporter: Howard M. Lewis Ship
Priority: Minor
This is based on some customer work.
Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Vjeran Marcinko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882493#action_12882493 ]
Vjeran Marcinko commented on TAP5-1190:
---------------------------------------
Would it be useful for QueryParameterMapped annotation to have some "required" argument to specify that this query parameter is required, or the policy is that required arguments should go to page activation context?
I'm asking this because I don't care in my web apps whether "page parameters" are passed as path info or query parameters, but since I can see that this way is more powerful because parameters can be *named and optional*, and using annotation way is *much* more clear than using methods for setting and extracting them (@PageActivationContext is nice but it only works for single parameter), I will probably end up using this new way all the time instead of activation context.
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1190.
--------------------------------------
Fix Version/s: 5.2.0
Resolution: Fixed
A powerful new addition to Tapestry puts URL query parameters on nearly equal footing with extra path information
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1190:
------------------------------------------
Assignee: Howard M. Lewis Ship
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1190:
------------------------------------------
Assignee: Howard M. Lewis Ship
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1190.
--------------------------------------
Fix Version/s: 5.2.0
Resolution: Fixed
A powerful new addition to Tapestry puts URL query parameters on nearly equal footing with extra path information
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Vjeran Marcinko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882493#action_12882493 ]
Vjeran Marcinko commented on TAP5-1190:
---------------------------------------
Would it be useful for QueryParameterMapped annotation to have some "required" argument to specify that this query parameter is required, or the policy is that required arguments should go to page activation context?
I'm asking this because I don't care in my web apps whether "page parameters" are passed as path info or query parameters, but since I can see that this way is more powerful because parameters can be *named and optional*, and using annotation way is *much* more clear than using methods for setting and extracting them (@PageActivationContext is nice but it only works for single parameter), I will probably end up using this new way all the time instead of activation context.
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883244#action_12883244 ]
Hudson commented on TAP5-1190:
------------------------------
Integrated in tapestry-5.2-freestyle #148 (See [http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/148/])
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1190) New page-level events to "decorate"
component event and page render links
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883244#action_12883244 ]
Hudson commented on TAP5-1190:
------------------------------
Integrated in tapestry-5.2-freestyle #148 (See [http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/148/])
> New page-level events to "decorate" component event and page render links
> -------------------------------------------------------------------------
>
> Key: TAP5-1190
> URL: https://issues.apache.org/jira/browse/TAP5-1190
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> This is based on some customer work.
> Customer really wanted URLs to include a series of (optional) values as query parameters, not path info ... which makes sense, because you'd have a category filter sometimes, a name filter sometimes, etc.
> Anyway, this worked fine in most cases ... there's a method on the page to act like the passivate event handler, but return a Link with the query parameters added. The active event handler would extract the query parameters and store them inside fields.
> Got trickier handling event links; had to modify some low-level components to fire a "decorateLink" event so that the page's event handler could add the query parameters to the link.
> It would be nice if these concepts were inside Tapestry; that after generating a Link via the passivate event (or by building a Link using a supplied page activation context) that an optional event (perhaps called "decorateLink") would be triggered to add these extra query parameters.
> Ideally, there would be two events, "decoratePageRenderLink" and "decorateComponentEventLink". The first parameter would be the Link to decorate. The second would be the PageRenderRequestParameters or ComponentEventRequestParameters, as appropriate. This would give the event handler method enough information to decide whether to decorate the link, and what information to put into it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.