You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/07 07:10:18 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #2675: Use BitIndexIterator in min_max_helper
viirya opened a new pull request, #2675:
URL: https://github.com/apache/arrow-rs/pull/2675
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
```
min nulls 512 time: [1.0670 µs 1.0697 µs 1.0736 µs]
change: [-43.808% -43.357% -42.886%] (p = 0.00 < 0.05)
Performance has improved.
max nulls 512 time: [1.1034 µs 1.1092 µs 1.1142 µs]
change: [-44.535% -44.077% -43.658%] (p = 0.00 < 0.05)
Performance has improved.
min string 512 time: [1.5545 µs 1.5591 µs 1.5655 µs]
change: [-2.2943% -1.8124% -1.3211%] (p = 0.00 < 0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severe
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2675: Use BitIndexIterator in min_max_helper
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2675:
URL: https://github.com/apache/arrow-rs/pull/2675#issuecomment-1239420525
Benchmark runs are scheduled for baseline = c8bf1ca39d28d2983feb2639309bac0f5318b04a and contender = b36bc88296e0a63e8bcaae1fd63f0f3d3ec9331c. b36bc88296e0a63e8bcaae1fd63f0f3d3ec9331c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/807ba8a6277f41e1a005af358b12ce23...b4680f3aa46d4212bd2398f516d08394/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6bfa88e266074242890b4bb6c2a33632...d5f3dd3c0aad45bbba668b440d9d4999/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ad4cf4bfb9c440d381a53174f5856a19...b2fbfc7522bb4761b20a40304c3e91b7/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1aae327aed1c4d5ebe6442724e8626cf...b2da63904c6945bfb6b1ea389f5ce678/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan merged pull request #2675: Use BitIndexIterator in min_max_helper
Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #2675:
URL: https://github.com/apache/arrow-rs/pull/2675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org