[jira] Commented: (OFBIZ-715) Utils for doing date calculations based on timeUomIds

["Adrian Crum (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507481 ] 

Adrian Crum commented on OFBIZ-715:
-----------------------------------

Andrew,

The latest version of UtilDateTime.java has an adjustTimestamp method that achieves most of what you have in this patch. I'm curious - why is it necessary to specify the adjustment type as a String data type? That seems to add an unnecessary level of complication to the methods in your patch.

As far as the elasped time computations are concerned, I like the fact that you didn't attempt to perform millisecond arithmetic. However, looping through dates until a match is found seems kind of clunky. I would like to see an accurate elasped time method added to UtilDateTime - maybe we can put our heads together and come up with a different solution.


> Utils for doing date calculations based on timeUomIds
> -----------------------------------------------------
>
>                 Key: OFBIZ-715
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-715
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Andrew Sykes
>            Priority: Minor
>         Attachments: UtilDateTime.java.patch, UtilDateTime.java.patch
>
>
> 6 new methods, 
> 1/ adjustDateTime (3 methods) adjusts either a Timestamp Date or Calendar by the given timeUomId and timeUomMultiple
> 2/ getTimeUomMultipleDifference (3 methods) gets the timeUomMultiple for two Timestamp Date or Calendar objects given the timeUomId.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.