You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/19 01:26:18 UTC
[GitHub] [airflow] kaxil opened a new pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``
kaxil opened a new pull request #17708:
URL: https://github.com/apache/airflow/pull/17708
Follow-up of https://github.com/apache/airflow/pull/16267
Renames `task_concurrency` to `max_active_tis_per_dag`
Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example:
https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation
https://stackoverflow.com/questions/38200666/airflow-parallelism
This PR is an attempt to make the settings easier to understand
**ToDo**:
- [ ] Add note in UPDATING.md
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17708:
URL: https://github.com/apache/airflow/pull/17708#discussion_r691714139
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -887,6 +887,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
+ 'max_active_tis_per_dag': None,
Review comment:
What's the purpose of this test BTW? We had another PR About it and I was not sure why we have the list here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17708:
URL: https://github.com/apache/airflow/pull/17708#issuecomment-901542707
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17708:
URL: https://github.com/apache/airflow/pull/17708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17708:
URL: https://github.com/apache/airflow/pull/17708#discussion_r692091900
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -887,6 +887,7 @@ def test_no_new_fields_added_to_base_operator(self):
'executor_config': {},
'inlets': [],
'label': '10',
+ 'max_active_tis_per_dag': None,
Review comment:
This list just makes sure that if new fields are added to the base operator we add it here, in case it needs any special treatment for DAG Serialization (helpful if they are dicts and lists)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org