You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 22:47:52 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #19663: Update Airflow release guide

jedcunningham commented on a change in pull request #19663:
URL: https://github.com/apache/airflow/pull/19663#discussion_r751702843



##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -757,16 +783,17 @@ previously released RC candidates in "${AIRFLOW_SOURCES}/dist":
 - Upload the package to PyPI's production environment:
 
     ```shell script
-    twine upload -r pypi dist/*
+    twine upload -r pypi *.whl *${VERSION}.tar.gz

Review comment:
       It'd have to be this:
   
   ```suggestion
       twine upload -r pypi *${VERSION}-py3-none-any.whl *${VERSION}.tar.gz
   ```
   
   At that point, might even be worth removing globbing:
   
   ```suggestion
       twine upload -r pypi apache_airflow-${VERSION}-py3-none-any.whl apache-airflow-${VERSION}.tar.gz
   ```
   
   No strong preference tbh.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org