You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/04/19 11:27:16 UTC
[GitHub] [kylin] Mukvin opened a new pull request, #1858: Add sample jobv2
Mukvin opened a new pull request, #1858:
URL: https://github.com/apache/kylin/pull/1858
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :
1. The original branch _kylin-on-parquet-v2_ for **Kylin 4.X** (Parquet Storage) has been renamed to branch **main**, and configured as the **default** branch;
2. The original branch _master_ for **Kylin 3.X** (HBase Storage) has been renamed to branch **kylin3** ;
Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1103698908
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`main@0fa4176`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1858 +/- ##
=======================================
Coverage ? 24.56%
Complexity ? 4458
=======================================
Files ? 1103
Lines ? 62384
Branches ? 8926
=======================================
Hits ? 15327
Misses ? 45442
Partials ? 1615
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0fa4176...11edc39](https://codecov.io/gh/apache/kylin/pull/1858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1105102768
This pull request **introduces 1 alert** when merging 339d700d81852d81d943f8103adaf71a71994af2 into 0fa41762ec0fc69c0b8029fc8a81b273388bbf1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-1109df7adbe2f12d10d1cce04c1587b516d5df0c)
**new alerts:**
* 1 for Dereferenced variable is always null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1105054128
This pull request **introduces 1 alert** when merging 6c191cb35d291aec957bc7f06508d8bc03bf9f0b into 0fa41762ec0fc69c0b8029fc8a81b273388bbf1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-1d2c86a4c91172dcf6dec60b240f9498424321ab)
**new alerts:**
* 1 for Dereferenced variable is always null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
hit-lacus merged PR #1858:
URL: https://github.com/apache/kylin/pull/1858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1106052781
This pull request **introduces 1 alert** when merging 6cccf979d4e9bd7615424bb11285758e3c09be5f into 0fa41762ec0fc69c0b8029fc8a81b273388bbf1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-90223f2dcb453ddb72d85e14c61609a39b6e8a11)
**new alerts:**
* 1 for Dereferenced variable is always null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1103469875
This pull request **introduces 1 alert** when merging 11edc39564373d543f78359210da586f2e347d92 into 0fa41762ec0fc69c0b8029fc8a81b273388bbf1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-1844a6ed37d41c3e967e449b3cdb9f15320abcc1)
**new alerts:**
* 1 for Dereferenced variable is always null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1858: Add sample jobv2
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #1858:
URL: https://github.com/apache/kylin/pull/1858#issuecomment-1103847705
This pull request **introduces 1 alert** when merging b193b1e5aec4514f1eab04afae83c5355b2a8bc7 into 0fa41762ec0fc69c0b8029fc8a81b273388bbf1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-55445605a7796c86e8fcad09fb0717e89b23032e)
**new alerts:**
* 1 for Dereferenced variable is always null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org