You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/29 00:41:04 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9040:
[fix] Adding show to FAB CRUD set
john-bodley opened a new pull request #9040: [fix] Adding show to FAB CRUD set
URL: https://github.com/apache/incubator-superset/pull/9040
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Fixes https://github.com/apache/incubator-superset/issues/9039.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Tested locally.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9040: [fix]
Adding show to FAB CRUD set
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9040: [fix] Adding show to FAB CRUD set
URL: https://github.com/apache/incubator-superset/pull/9040#issuecomment-579543885
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=h1) Report
> Merging [#9040](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2fc3d84b5aedfd8f4b74e5e18310c813d639c95f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9040 +/- ##
=======================================
Coverage 59.43% 59.43%
=======================================
Files 369 369
Lines 11743 11743
Branches 2884 2884
=======================================
Hits 6980 6980
Misses 4584 4584
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=footer). Last update [2fc3d84...ccacd36](https://codecov.io/gh/apache/incubator-superset/pull/9040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9040: [fix]
Adding show to FAB CRUD set
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9040: [fix] Adding show to FAB CRUD set
URL: https://github.com/apache/incubator-superset/pull/9040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org