You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/10/09 06:04:40 UTC
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #36: SCB-1500 decouple primitive.ObjectID
tianxiaoliang commented on a change in pull request #36: SCB-1500 decouple primitive.ObjectID
URL: https://github.com/apache/servicecomb-kie/pull/36#discussion_r332840513
##########
File path: server/service/mongo/kv/kv_service.go
##########
@@ -74,7 +75,7 @@ func (s *Service) CreateOrUpdate(ctx context.Context, kv *model.KVDoc) (*model.K
}
}
- kv.LabelID = labelID.Hex()
+ kv.LabelID = string(labelID)
Review comment:
labelID's type is id.ID
kv.LabeldID's type is string
need to convet it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services