You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2025/01/31 05:27:19 UTC
[PR] Update release script to use JDK 17 for branch-3+ [hbase]
stoty opened a new pull request, #6655:
URL: https://github.com/apache/hbase/pull/6655
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2630513426
> My recollection was that not just the Unsafe is an issue. There was a bug in javac such that it would still produce opcodes that were not compatible with JDK8, even when the compiler target/release was set. Maybe the JDK devs finally acknowledged and fixed the bug?
>
> I haven't tried it recently so I'd be happy to stand corrected.
Use `target` only means generating bytecode with the given version, but it will still use the symbols of the JDK version which is used to compile the code, so there could still be incompatible issues, like the byte buffer problem provided above by @stoty .
Use `release` not only means generating bytecode for the given version, it will also use the symbols of the JDK version for keeping compatible.
The JDK bug in HBASE-26773 is for sun.misc.Unsafe, the JDK team does not want to expose this module at compile time, so it will lead to a compile error if you use these symbols, but it will not introduce any compatible issue at runtime.
This is my understanding.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2629968524
Thanks for reminding me. I knew I couldn't build with JDK17, but I didn't remember that Unsafe was the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2626342882
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | spotless | 0m 42s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | | Maven dependency ordering for patch |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | hadolint | 0m 0s | | No new issues. |
| -0 :warning: | shellcheck | 0m 2s | [/results-shellcheck.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6655/1/artifact/yetus-general-check/output/results-shellcheck.txt) | The patch generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17) |
| +1 :green_heart: | spotless | 0m 48s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | | ASF License check generated no output? |
| | | 3m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6655/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6655 |
| Optional Tests | dupname asflicense codespell detsecrets hadolint shellcheck shelldocs spotless |
| uname | Linux bbcb64997965 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 050f03c14b8ce1240bc4433b6503ad42bb2e12f0 |
| Max. process+thread count | 46 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6655/1/console |
| versions | git=2.34.1 maven=3.9.8 hadolint=2.10.0 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2630463838
I don't know.
We'd need to solve the unsafe issue before we could test that.
I think we should build the public binaries with the lowest supported JDK anyway, that's the safest bet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2628992182
See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2628991089
The most reliable way to build a JDK8 compatible binary is to use JDK8.
IIRC JDK17 does not support Java 8 via the --release flag, and -target alone does not guarantee backward compatibility.
These changes check the minimum java version defined in the POM, and only activate JDK17 if it is set in the pom.
Unless I messed something up, this should have zero effect on branch-2 builds (The docker image still defaults to Java 8, as set by the alternatives command)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2628976142
IIRC, we still support JDK8 runtime on branch-2.5,6. We need to verify that a binary release produced using JDK17 will run on a JDK8 runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2626340950
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | | Maven dependency ordering for patch |
|||| _ Other Tests _ |
| | | 1m 27s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6655/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6655 |
| Optional Tests | |
| uname | Linux d523e6a1fb6f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 050f03c14b8ce1240bc4433b6503ad42bb2e12f0 |
| Max. process+thread count | 41 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6655/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2630191442
My recollection was that not just the Unsafe is an issue. There was a bug in javac such that it would still produce opcodes that were not compatible with JDK8, even when the compiler target/release was set. Maybe the JDK devs finally acknowledged and fixed the bug?
I haven't tried it recently so I'd be happy to stand corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2628963215
I think we could use JDK17 for all branches? We only need JDK17 for building hbase thirdparty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2629423912
Now we use '--relesae 8' to compile the code so it is OK to use JDK11 or JDK17 to build JDK8 binaries.
The only problem is about the jdk.unsupported module, where sun.misc.Unsafe is in it but at compile time, we still can not see the module which will cause compile error. So the decision is to move the related code to hbase-thirdparty, and build hbase-thirdparty with JDK8, then the main repo can be built with JDK11 or JDK17.
Please see HBASE-26773.
But anyway, the approach in this PR can work too, so I'm OK with the current approach.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #6655:
URL: https://github.com/apache/hbase/pull/6655#issuecomment-2629435733
Ah, I forgot one thing that, if we want to build with hadoop2.x, we need to use JDK8, there is an enforcer rule for it, since hadoop 2.x can not run with JDK11+, it is useless to build it with JDK11+...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29105 Update release script to use JDK 17 for branch-3+ [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty merged PR #6655:
URL: https://github.com/apache/hbase/pull/6655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org