[impala] 04/05: IMPALA-9427 Add -fsigned-char compile option

[tm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit ded55d696acaaf2b87227f7f23b7fb799a80e872
Author: zhaorenhai <zh...@hotmail.com>
AuthorDate: Wed Feb 26 10:51:48 2020 +0000

    IMPALA-9427 Add -fsigned-char compile option
    
    On aarch64 platform, type of char default is unsigned char,
    
    here set it to signed-char to be compatible with x86-64
    
    Change-Id: I4f0f8159b2e1167413fa3b577ad1f8db1da983a5
    Reviewed-on: http://gerrit.cloudera.org:8080/15299
    Reviewed-by: Tim Armstrong <ta...@cloudera.com>
    Tested-by: Tim Armstrong <ta...@cloudera.com>
---
 be/CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/be/CMakeLists.txt b/be/CMakeLists.txt
index 42fa315..c7bd31a 100644
--- a/be/CMakeLists.txt
+++ b/be/CMakeLists.txt
@@ -35,6 +35,8 @@ PROJECT(ASSEMBLER)
 #   -fno-strict-aliasing: disable optimizations that assume strict aliasing. This
 #       is unsafe to do if the code uses casts (which we obviously do).
 #  -Wno-unknown-pragmas: suppress warnings for unknown (compiler specific) pragmas
+#  -fsigned-char: on aarch64 platform, type of char default is unsigned char, here
+#        set it to signed-char to be compatible with x86-64
 #  -Wno-deprecated: gutil contains deprecated headers
 #  -Wno-vla: we use C99-style variable-length arrays
 #  -pthread: enable multithreaded malloc
@@ -42,6 +44,7 @@ PROJECT(ASSEMBLER)
 #  -fno-omit-frame-pointers: Keep frame pointer for functions in register
 SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare -Wno-unknown-pragmas -pthread")
 SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing -fno-omit-frame-pointer")
+SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fsigned-char")
 SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=c++14")
 SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-deprecated -Wno-vla")
 SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG")