You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2014/08/19 03:30:44 UTC
Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/
-----------------------------------------------------------
Review request for hive and Gunther Hagleitner.
Repository: hive-git
Description
-------
Some queries like
{code}
select * from table where dcol<=11.22BD;
{code}
fails when ORC predicate pushdown is enabled.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
Diff: https://reviews.apache.org/r/24834/diff/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/#review50955
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
<https://reviews.apache.org/r/24834/#comment88847>
No. It is not immediate return. It just takes the underlying object value from constant expression node to make it suitable for type conversion.
This type coercion is necessary to match the types of column stats object and predicate object. In some cases, predicate object type is embeded within ExprNodeConstantDesc which is why we need to extract the actual value out of it.
- Prasanth_J
On Aug. 19, 2014, 1:32 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24834/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 1:32 a.m.)
>
>
> Review request for hive, Gopal V and Gunther Hagleitner.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Some queries like
> {code}
> select * from table where dcol<=11.22BD;
> {code}
> fails when ORC predicate pushdown is enabled.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
> ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
> ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
>
> Diff: https://reviews.apache.org/r/24834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 5:59 p.m.)
Review request for hive, Gopal V and Gunther Hagleitner.
Changes
-------
Added unit test for big decimal support in search argument.
Repository: hive-git
Description
-------
Some queries like
{code}
select * from table where dcol<=11.22BD;
{code}
fails when ORC predicate pushdown is enabled.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 2c53f65
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
Diff: https://reviews.apache.org/r/24834/diff/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 5:51 p.m.)
Review request for hive, Gopal V and Gunther Hagleitner.
Changes
-------
Added support for BigDecimal in SARG construction.
Repository: hive-git
Description
-------
Some queries like
{code}
select * from table where dcol<=11.22BD;
{code}
fails when ORC predicate pushdown is enabled.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 2c53f65
ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
Diff: https://reviews.apache.org/r/24834/diff/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/#review50950
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
<https://reviews.apache.org/r/24834/#comment88843>
Does this imply an immediate return?
Is there are reason we go through the type coercion codepaths after getting the value out of the object?
- Gopal V
On Aug. 19, 2014, 1:32 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24834/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 1:32 a.m.)
>
>
> Review request for hive, Gopal V and Gunther Hagleitner.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Some queries like
> {code}
> select * from table where dcol<=11.22BD;
> {code}
> fails when ORC predicate pushdown is enabled.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
> ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
> ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
>
> Diff: https://reviews.apache.org/r/24834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 24834: HIVE-7771: ORC PPD fails for some decimal
predicates
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24834/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 1:32 a.m.)
Review request for hive, Gopal V and Gunther Hagleitner.
Changes
-------
+Gopal
Repository: hive-git
Description
-------
Some queries like
{code}
select * from table where dcol<=11.22BD;
{code}
fails when ORC predicate pushdown is enabled.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/queries/clientpositive/orc_ppd_decimal.q a93590e
ql/src/test/results/clientpositive/orc_ppd_decimal.q.out 0c11ea8
Diff: https://reviews.apache.org/r/24834/diff/
Testing
-------
Thanks,
Prasanth_J