[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3199: One tid for the whole system.
URL: https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r185510417
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
 ##########
 @@ -39,10 +34,10 @@ import pureconfig._
  */
 case class TransactionId private (meta: TransactionMetadata) extends AnyVal {
   def id = meta.id
-  override def toString = {
-    if (meta.id > 0) s"#tid_${meta.id}"
-    else if (meta.id < 0) s"#sid_${-meta.id}"
-    else "??"
+  override def toString = s"#tid_${meta.id}"
 
 Review comment:
   will a tid now appear as `tid_sid_...` in the logs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services