You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2016/09/08 11:33:13 UTC

Re: Review Request 50740: Lens Druid sql rewriter changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50740/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 11:33 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Changes post review comments


Bugs: LENS-1224
    https://issues.apache.org/jira/browse/LENS-1224


Repository: lens


Description (updated)
-------

Changes done include : 
1. Druid sql rewriter in Jdbc driver
2. BetweenTimerangerewriter changes for Druid
3. HQLParser toString modified


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java a5b26c4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 49ed5ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 68cdcef 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java eeba861 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 748f92f 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b1fd459 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java PRE-CREATION 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java PRE-CREATION 
  lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/50740/diff/


Testing
-------


Thanks,

Rajitha R

Re: Review Request 50740: Lens Druid sql rewriter changes

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50740/#review148895
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On Sept. 8, 2016, 5:51 p.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50740/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 5:51 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-1224
>     https://issues.apache.org/jira/browse/LENS-1224
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes done include : 
> 1. Druid sql rewriter in Jdbc driver
> 2. BetweenTimerangerewriter changes for Druid
> 3. HQLParser toString modified
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java a5b26c4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 49ed5ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 68cdcef 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java eeba861 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 748f92f 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b1fd459 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java PRE-CREATION 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java PRE-CREATION 
>   lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 50740: Lens Druid sql rewriter changes

Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50740/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 12:21 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Checkstyle fix


Bugs: LENS-1224
    https://issues.apache.org/jira/browse/LENS-1224


Repository: lens


Description
-------

Changes done include : 
1. Druid sql rewriter in Jdbc driver
2. BetweenTimerangerewriter changes for Druid
3. HQLParser toString modified


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java a5b26c4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 49ed5ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 68cdcef 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java eeba861 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 748f92f 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b1fd459 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java PRE-CREATION 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java PRE-CREATION 
  lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/50740/diff/


Testing
-------


Thanks,

Rajitha R