[GitHub] matthiasblaesing commented on a change in pull request #872: Relicensed leftover file, excluded cordova testing data

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #872: Relicensed leftover file, excluded cordova testing data
URL: https://github.com/apache/incubator-netbeans/pull/872#discussion_r217376741
 
 

 ##########
 File path: webcommon/cordova.platforms.ios/licenseinfo.xml
 ##########
 @@ -21,6 +21,13 @@
 -->
 <licenseinfo>
     <fileset>
+        <!-- Test data, should not contain comments -->
+        <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/disconnected.xml</file>
+        <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/jsoncommand.xml</file>
+        <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/listing.xml</file>
+        <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/toback.xml</file>
+        <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/tofront.xml</file>
 
 Review comment:
   I would just add the ALv2 header and be done with it. No need to exclude the files. The exception you could pull here (https://www.apache.org/legal/src-headers.html#faq-exceptions) is:
   
   > Other files may make sense to have no license header. [...]
   > - Test data for which the addition of a source header would cause the tests to fail. 
   > [...]
   
   That is not the case here. The unittests are not position dependend and as far as I can see they use an XML parser to process the XML data, so a normal XML comment should not hurt.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists